718705 - Doorhanger prompts again to remember password after going back to page

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P5)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, steps to reproduce:

- Visit testcase, fill in some values for the 2 inputs you see at the top
- Submit the form, the password manager doorhanger notification pops up
- Press the Android back button to dismiss it
- Press the Android back button again to go back a page

Expected result:
- Nothing happening (apart from going back a page)

Actual result:
- Password manager doorhanger notification pops up again.

Comment 1

[Martijn Wargers (dead)]

Bugzilla might interfere with the str, so the testcase is here also: http://people.mozilla.org/~mwargers/tests/forms/password/password.html

Comment 2

[:Margaret Leibovic]

This is happening because of the timeout we're setting on the doorhanger. We have to set a timeout to persist this remember password doorhanger for a certain amount of time because website authentication systems can sometimes have multiple redirects, so we can't just say we'll keep the notification for one location change.

There's no perfect solution here, but we kinda dealt with this for desktop in bug 595175 by also adding a "persistWhileVisible" option that always keeps the doorhanger around if it hasn't been dismissed. We could do something like that for mobile, but it might be more complicated because of the Java/Gecko divide. I'm not sure if it's worth it.

Comment 3

[Doug Turner (:dougt)]

agreed.

Comment 4

[:Margaret Leibovic]

Attachment: patch

This patch just ports over the desktop change from bug 595175 (I also added docs for the checkbox option, since I didn't do that before).

If you navigate quickly, the doorhanger will still reappear because of the timeout. I think we kept the timeout on desktop because we didn't want the user to be screwed if he/she accidentally clicked outside the doorhanger. However, we have no way to bring back the popups on mobile right now, so the user gets screwed all the time, so maybe we should get rid of the timeout on mobile?

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 638826 [details] [diff] [review]
patch

Let's leave the timeout for now and see how it works.

Comment 6

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/864b5965c87b

Comment 7

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/864b5965c87b