759237 - nsIMsgPluggableStore.discoverSubFolders should not raise NS_MSG_FOLDER_EXISTS exception.

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

Attachment: Fix

The method traverses all sub folders so that NS_MSG_FOLDER_EXISTS is not proper for this method.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Fix

The previous patch has an incorrect fix in nsMsgMaildirStore.cpp. Sorry for my careless.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Fix

create_sub_folders had been accidentally removed in unit test. I am so sorry for my careless.

Comment 3

[:aceman]

Does this fix any known problems? There is a mention of this error code in bug 749574.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

(In reply to :aceman from comment #3)
> Does this fix any known problems? There is a mention of this error code in
> bug 749574.

Wow! Nice catch! As far as I can confirm, the fix for bug 756316 (and the fix for this bug) fixes bug 749574 too.

Comment 5

[David :Bienvenu]

Comment on attachment 627855 [details] [diff] [review]
Fix

Hiro, thx very much for the patch. I'm wondering why you didn't change AddSubFolders instead - you could certainly argue that it should not return NS_MSG_FOLDER_EXISTS. I think that would be cleaner, but I my build isn't finished so I haven't been able to try it.

Comment 6

[David :Bienvenu]

Attachment: tweak AddSubFolders instead...

Hiro, this is what I had in mind...with this change, the test works, like it does with initial version. I think I prefer this version, so I've r+'d it. If you're OK with it, we can land it. I'd like to get this into tb 13 which means landing it today, if possible.

Comment 7

[David :Bienvenu]

I'd like to consider this for tb 13 final beta, since it fixes several issues users with localized builds have been seeing.

Comment 8

[David :Bienvenu]

I've requested a try server build here - http://ftp.mozilla.org/pub/mozilla.org/thunderbird/try-builds/[e-mail]-1da6acf730bf

I think this change is relatively safe, since discoverSubFolders shouldn't care about folders existing.

Comment 9

[Mark Banner (:standard8)]

Comment on attachment 627988 [details] [diff] [review]
tweak AddSubFolders instead...

[Triage Comment]
Per discussion on irc, we're going to take the risk for this as it is hurting users in some cases, especially with localised folders.

Comment 10

[David :Bienvenu]

trunk - http://hg.mozilla.org/comm-central/rev/27498a828ee9 (forgot bug #)
aurora - http://hg.mozilla.org/releases/comm-aurora/rev/3c22e945104c
beta - http://hg.mozilla.org/releases/comm-beta/rev/c2e021ccbd53

first two commits omitted the bug # unfortunately

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 627855 [details] [diff] [review]
Fix

I believe this request is obsolete, clearing.