Note: There are a few cases of duplicates in user autocompletion which are being worked on.

rename nsHTMLImageAccessible to ImageAccessible

RESOLVED FIXED in mozilla15

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: surkov, Assigned: capella)

Tracking

(Blocks: 1 bug)

unspecified
mozilla15
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
1) rename nsHTMLImageAccessible to ImageAccessible
2) move it to mozilla::a11y namespace
3) move files to generic folder
(Assignee)

Updated

5 years ago
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
(Assignee)

Comment 1

5 years ago
Created attachment 629426 [details] [diff] [review]
Patch (v1)

Renamed, moved to /generic, header guards updated, and moved to namespace.
Attachment #629426 - Flags: review?(surkov.alexander)
(Reporter)

Comment 2

5 years ago
Comment on attachment 629426 [details] [diff] [review]
Patch (v1)

Review of attachment 629426 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, nice

::: accessible/src/html/nsHTMLImageAccessible.h
@@ +30,5 @@
>  
>    // nsIAccessible
>    NS_IMETHOD GetActionName(PRUint8 aIndex, nsAString& aName);
>    NS_IMETHOD DoAction(PRUint8 index);
>  

somewhere here you forgot about mozilla::a11y::role

::: accessible/src/msaa/ia2AccessibleImage.cpp
@@ +9,5 @@
>  
>  #include "AccessibleImage_i.c"
>  
> +#include "ImageAccessible.h"
> +#include "ImageAccessibleWrap.h"

it's enough include wrap file only

@@ +46,5 @@
>  __try {
>    *aDescription = NULL;
>  
> +  ImageAccessibleWrap* acc =
> +    static_cast<ImageAccessibleWrap*>(this);

keep on the same line

@@ +75,5 @@
>    *aX = 0;
>    *aY = 0;
>  
> +  ImageAccessibleWrap* imageAcc =
> +    static_cast<ImageAccessibleWrap*>(this);

same

@@ +105,5 @@
>    *aHeight = 0;
>    *aWidth = 0;
>  
> +  ImageAccessibleWrap* imageAcc =
> +    static_cast<ImageAccessibleWrap*>(this);

and here
Attachment #629426 - Flags: review?(surkov.alexander) → review+
(Assignee)

Comment 3

5 years ago
FYI, for accessible.h and nsHTMLImageAccessible.h, changing mozilla::a11y::role to role causes a type def not found, and using a11y::role complains a11y is not a namespace, so I had to leave it as-is.

I was able to change ImageAccessible.h though.
(Reporter)

Comment 4

5 years ago
(In reply to Mark Capella [:capella] from comment #3)
> FYI, for accessible.h and nsHTMLImageAccessible.h, changing
> mozilla::a11y::role to role causes a type def not found, and using
> a11y::role complains a11y is not a namespace, so I had to leave it as-is.

> I was able to change ImageAccessible.h though.

it's true for Accessible.h since it's not in a11y namespace.

I didn't get about nsHTMLImageAccessible.h and ImageAccessible.h since it's the same but if I read you right then in former case you didn't change it but in the second case you did that.
(Assignee)

Comment 5

5 years ago
Yes.
(Reporter)

Comment 6

5 years ago
(In reply to Mark Capella [:capella] from comment #5)
> Yes.

sorry, yes what?
(Assignee)

Comment 7

5 years ago
Created attachment 629434 [details] [diff] [review]
Patch (v2)

I wasn't able to change nsHTMLImageAccessible.h, but I able to for ImageAccessible.h.
Attachment #629426 - Attachment is obsolete: true
(Assignee)

Comment 8

5 years ago
Yes sorry, I'm just confusing you here. Same one before/after, see the diff for clarity.
(Reporter)

Comment 9

5 years ago
(In reply to Mark Capella [:capella] from comment #7)
> Created attachment 629434 [details] [diff] [review]
> Patch (v2)
> 
> I wasn't able to change nsHTMLImageAccessible.h, but I able to for
> ImageAccessible.h.

ok, got it. you did a build in the middle of progress or try to change that previously.
(Assignee)

Comment 10

5 years ago
TRY Push
https://tbpl.mozilla.org/?tree=Try&rev=07d55b4ddc69
(Assignee)

Comment 11

5 years ago
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=d2624fac9886
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/d2624fac9886
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.