759307 - rename nsHTMLImageAccessible to ImageAccessible

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

1) rename nsHTMLImageAccessible to ImageAccessible
2) move it to mozilla::a11y namespace
3) move files to generic folder

Comment 1

[Mark Capella [:capella]]

Attachment: Patch (v1)

Renamed, moved to /generic, header guards updated, and moved to namespace.

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 629426 [details] [diff] [review]
Patch (v1)

Review of attachment 629426 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, nice

::: accessible/src/html/nsHTMLImageAccessible.h
@@ +30,5 @@
>  
>    // nsIAccessible
>    NS_IMETHOD GetActionName(PRUint8 aIndex, nsAString& aName);
>    NS_IMETHOD DoAction(PRUint8 index);
>  

somewhere here you forgot about mozilla::a11y::role

::: accessible/src/msaa/ia2AccessibleImage.cpp
@@ +9,5 @@
>  
>  #include "AccessibleImage_i.c"
>  
> +#include "ImageAccessible.h"
> +#include "ImageAccessibleWrap.h"

it's enough include wrap file only

@@ +46,5 @@
>  __try {
>    *aDescription = NULL;
>  
> +  ImageAccessibleWrap* acc =
> +    static_cast<ImageAccessibleWrap*>(this);

keep on the same line

@@ +75,5 @@
>    *aX = 0;
>    *aY = 0;
>  
> +  ImageAccessibleWrap* imageAcc =
> +    static_cast<ImageAccessibleWrap*>(this);

same

@@ +105,5 @@
>    *aHeight = 0;
>    *aWidth = 0;
>  
> +  ImageAccessibleWrap* imageAcc =
> +    static_cast<ImageAccessibleWrap*>(this);

and here

Comment 3

[Mark Capella [:capella]]

FYI, for accessible.h and nsHTMLImageAccessible.h, changing mozilla::a11y::role to role causes a type def not found, and using a11y::role complains a11y is not a namespace, so I had to leave it as-is.

I was able to change ImageAccessible.h though.

Comment 4

[alexander :surkov (:asurkov)]

(In reply to Mark Capella [:capella] from comment #3)
> FYI, for accessible.h and nsHTMLImageAccessible.h, changing
> mozilla::a11y::role to role causes a type def not found, and using
> a11y::role complains a11y is not a namespace, so I had to leave it as-is.

> I was able to change ImageAccessible.h though.

it's true for Accessible.h since it's not in a11y namespace.

I didn't get about nsHTMLImageAccessible.h and ImageAccessible.h since it's the same but if I read you right then in former case you didn't change it but in the second case you did that.

Comment 5

[Mark Capella [:capella]]

Yes.

Comment 6

[alexander :surkov (:asurkov)]

(In reply to Mark Capella [:capella] from comment #5)
> Yes.

sorry, yes what?

Comment 7

[Mark Capella [:capella]]

Attachment: Patch (v2)

I wasn't able to change nsHTMLImageAccessible.h, but I able to for ImageAccessible.h.

Comment 8

[Mark Capella [:capella]]

Yes sorry, I'm just confusing you here. Same one before/after, see the diff for clarity.

Comment 9

[alexander :surkov (:asurkov)]

(In reply to Mark Capella [:capella] from comment #7)
> Created attachment 629434 [details] [diff] [review]
> Patch (v2)
> 
> I wasn't able to change nsHTMLImageAccessible.h, but I able to for
> ImageAccessible.h.

ok, got it. you did a build in the middle of progress or try to change that previously.

Comment 10

[Mark Capella [:capella]]

TRY Push
https://tbpl.mozilla.org/?tree=Try&rev=07d55b4ddc69

Comment 11

[Mark Capella [:capella]]

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=d2624fac9886

Comment 12

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/d2624fac9886