759346 - Ctrl+ช (The key is '+/=' key on ANSI keyboard layout) doesn't work as Ctrl++ but work as so on IE

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://bugzilla.mozilla.org/show_bug.cgi?id=756811#c16

>  Ekanan Ketunuti 2012-05-29 08:00:32 PDT
> 
> On Thai keyboard I use Ctrl and ช (+/= key in English) rather than Ctrl and Shift and ๅ. 
> 
> Since cset c9ce0e49040a I cannot use Ctrl and ช for zoom-in.

The key's virtual keycode is VK_OEM_PLUS. It's odd, the key cannot input '+' and '1' key can input '+' with Shift key. So, the key shouldn't be VK_OEM_PLUS. However, other applications checks the virtual keycode for kicking shortcut key handlers. So, we should add special case for it.

This is a regression of bug 630810, so, this must be fixed on Fx15.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

testing on tryserver:
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1

This makes inconsistency between other platforms on some keyboard layout. However, it's better to emulate native application manners.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7f259a56c7c0

Comment 3

[Ekanan Ketunuti]

Thank you for fixing this!

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Ekanan Ketunuti from comment #3)
> Thank you for fixing this!

Thank *you* for your reporting. That always helps us.

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7f259a56c7c0

(In reply to Ekanan Ketunuti from comment #3)
> Thank you for fixing this!

The fix will be present in tomorrow's Nightly / Firefox 15 when it reaches aurora/beta/release :-)

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

This is fixed, and possibly uncommon, so untracking.