The default bug view has changed. See this FAQ.

ctrl++ doesn't work even with Ctrl+Shift++ when keyboard layout is Russian or Thai

RESOLVED FIXED in mozilla15

Status

()

Core
Widget: Win32
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Roman R., Unassigned)

Tracking

Trunk
mozilla15
x86
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/15.0 Firefox/15.0a1
Build ID: 20120519030527

Steps to reproduce:

1. Switch keyboard layout to a Russian one.
2. Pressed Ctrl and +


Actual results:

Nothing.


Expected results:

Zooming in.
(Reporter)

Comment 1

5 years ago
Ctrl+- and ctrl+0 work, though.

Comment 2

5 years ago
what about ctrl-shift-and then the [=/+] key?

you use to have to hold shift to get a [+] but this was fixed, is this the cause?

if you pres the + key alone, do you get a "+", a "=" or something else?
Ctrl+Shift+= should work.

I know most users don't want to press Shift key for such case. l10n builds can avoid this issue only on the most major keyboard layout in the location. See bug 426501.

But it's odd, both English build and Russian build sets "=" as the alternative zoom in shortcut key. So, Ctrl+= should work as zoom-in.
(Reporter)

Comment 4

5 years ago
Ctrl+Shift+= doesn't work.

By the way, we had this problem a few years ago: bug 429898.
(Reporter)

Comment 5

5 years ago
This got broken quite recently, I believe.
Roman, can you try some previous Firefox versions to see when this started happening? Also, does this happen with any other locales?
Component: Untriaged → Keyboard Navigation
Keywords: regressionwindow-wanted
QA Contact: untriaged → keyboard.navigation

Comment 7

5 years ago
this is a great tool to find out when this problem started: http://harthur.github.com/mozregression/

Comment 8

5 years ago
* http://mozilla.github.com/mozregression/
(Reporter)

Comment 9

5 years ago
I will try, Anthony.

Comment 10

5 years ago
this happen with Thai locale too.

Comment 11

5 years ago
last good nightly 2012-05-17
first bad nightly 2010-05-18
pushlog http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=762e95608da3&tochange=e794cef56df6

m-i build:
last good rev is 2c3647738e81
first bad rev is c9ce0e49040a
pushlog http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=2c3647738e81&tochange=c9ce0e49040a
Ah, okay, I see the cause. Thanks for investigating the regression range.

This is a regression of bug 630810, only affects Fx15. So, this must be fixed.
Assignee: nobody → masayuki
Status: UNCONFIRMED → ASSIGNED
tracking-firefox15: --- → ?
Component: Keyboard Navigation → Widget: Win32
Ever confirmed: true
Keywords: regressionwindow-wanted → regression
Product: Firefox → Core
QA Contact: keyboard.navigation → win32
Target Milestone: --- → mozilla15
Version: 15 Branch → Trunk
Blocks: 630810
Target Milestone: mozilla15 → ---
Summary: ctrl++ doesn't work when keyboard layout is not English → ctrl++ doesn't work even with Ctrl+Shift++ when keyboard layout is Russian or Thai
Oops. Russian shouldn't be same bug. Roman R., are you exactly using the standard Russian keyboard layout which is installed by default? In other words, if your answer is YES, the Thai layout's problem is another bug. I need your confirmation.
Canceling my request for blocking 15. My investigation is wrong. And I cannot reproduce this bug on Thai layout too. That's strange.

Roman R. and Ekanan:

Are you using standard keyboard layout, I mean it's installed on Windows? Or are you using 3rd party keyboard layout include custom keyboard layout which is made by a tool?
No longer blocks: 630810
Status: ASSIGNED → UNCONFIRMED
tracking-firefox15: ? → ---
Ever confirmed: false
Note that I tested:

* On Nightly (en-US) with Russian keyboard layout which is installed Windows7.
* On Nightly (en-US) with Thai keyboard layouts (both Kedmanee and Pattachote) which are installed Windows7.
* On Fx13 (ja-JP) with Russian keyboard layout.
* On Fx13 (ja-JP) with both Thai keyboard layouts.

Ctrl+Shift+= does work as Ctrl++ on Russian keyboard layout. The key is next to '-', the '-' key is next to '0'.

Ctrl+Shift+ๅ does work as Ctrl++ on Thai Kedmanee keyboard layout. The key is '1' in ANSI keyboard layout.

Ctrl+Shift+= does work as Ctrl++ on Thai Pattachote keyboard layout. The key is '1' in ANSI keyboard layout.

Comment 16

5 years ago
> Are you using standard keyboard layout, I mean it's installed on Windows? 

Yes


> Ctrl+Shift+ๅ does work as Ctrl++ on Thai Kedmanee keyboard layout. The key
> is '1' in ANSI keyboard layout.


Ok, I misunderstood. sorry about that :(

On Thai keyboard I use Ctrl and ช (+/= key in English) rather than Ctrl and Shift and ๅ. 

Since cset c9ce0e49040a I cannot use Ctrl and ช for zoom-in.
(In reply to Ekanan Ketunuti from comment #16)
> Ok, I misunderstood. sorry about that :(
> 
> On Thai keyboard I use Ctrl and ช (+/= key in English) rather than Ctrl and
> Shift and ๅ. 
> 
> Since cset c9ce0e49040a I cannot use Ctrl and ช for zoom-in.

Thank you for your confirmation. *Currently*, the change is intentional. The key's native virtual keycode is OEM_PLUS. Before the changeset, Gecko cares it as '+' key always. But after it, Gecko checks whether '+' is inputtable by the key. I checked on IE9, the key combination works as Zoom-in, so, I think it must be fixed before Fx15 but other bug.

I'll file a new bug for the Thai keyboard layout case.
We need some replies from the reporter...
Assignee: masayuki → nobody
Keywords: regression
(Reporter)

Comment 19

5 years ago
I use a layout DLL created by a third party. HOWEVER, I must add that this bug is NOT present in 16.0a1 (2012-06-16).
Then, this must be fixed by bug 759346.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 5 years ago
Depends on: 759346
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.