Closed Bug 759393 Opened 12 years ago Closed 12 years ago

UX for bookmarks/history import from Android

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox19 verified)

VERIFIED FIXED
Tracking Status
firefox19 --- verified

People

(Reporter: gcp, Assigned: ibarlow)

References

Details

(Keywords: uiwanted)

UX for bug 710330.

I will initially put an "Import" option in the Settings menu to test my implementation.

We might want to consider doing things like:

a) Upon the first launch, if there was nothing migrated from XUL (or even if there was), query the user though a doorhanger whether to import bookmarks/history from the stock browser.
(I think there are some UX questions here if the user just saw the "converting bookmarks" message from Profile Migration - they might wonder why they're asked "again")

b) Make this a "checkboxable" feature that checks on every Fennec startup whether there are some new bookmarks or history in the built-in browser, and imports them if so.
Blocks: 710330
Keywords: uiwanted
Some other nice things to consider: when you import the bookmarks, if you import a bookmark that already existed in Fennec, we'll pull out that bookmark from your bookmark structure and put it to the root (as Android bookmarks have no folders). 

We could in theory allow duplicate bookmarks (our schema supports it), but as Android bookmarks don't have anything like a GUID, importing twice would mean all your bookmarks get duplicated. And nobody wants that.
(In reply to Gian-Carlo Pascutto (:gcp) from comment #1)
> Some other nice things to consider: when you import the bookmarks, if you
> import a bookmark that already existed in Fennec, we'll pull out that
> bookmark from your bookmark structure and put it to the root (as Android
> bookmarks have no folders). 
> 
> We could in theory allow duplicate bookmarks (our schema supports it), but
> as Android bookmarks don't have anything like a GUID, importing twice would
> mean all your bookmarks get duplicated. And nobody wants that.

I think we should be careful that we don't move any bookmarks that are in desktop bookmark folders, since it seems users wouldn't expect or want their desktop bookmarks to be moving folders. I think we should just put all the Android system bookmarks in the mobile folder (the contents of that are what show up in the root bookmarks UI on fennec), and then just ignore duplicates in there.
Dupes should probably be skipped if their parents match, but added if they do not. Sounds simple (haha) and would solve that problem.

Actually, the fact that it doesn't work like that means that Profile Migration will currently refuse to migrate bookmarks that are in two folders (that's a bug).
Assignee: nobody → ibarlow
This is Ian's now, but two thoughts -

- should this be somewhere in a first-run flow?
- after that, probably doesn't deserve to be in menu; maybe in settings?
- on pre-ICS I could see putting this in a menu-button menu on the bookmarks screen, but in ICS that won't work
1) First-run: perhaps yes. Two issues:

a) If the users don't "definitely" switch to Firefox they might want to import more than once.
b) We already have an "import bookmarks and history" step for former XUL users. Need to consider the interactions.
c) We absolutely need to ask the user if they want to put their private data into the Google browser.

2) Settings looks most logical to me (The mockup UX I put into the feature itself does just that)


You can ignore my earlier rambling about this affecting desktop bookmarks; that's a bug which I've fixed.
I agree that it would be nice to ask if users want to import stock browser history/bookmarks on first-run, *but* I don't think a doorhanger is the right approach. We are already using a doorhanger asking them to send test info back to us, so we shouldn't keep pestering them with more and more menus.

It seems like this should be rolled in with a more comprehensive enhancement to the Fennec first-run experience, which should include how to handle 
- sync / sign-in to browser setup
- bookmarks/history import from android
- some form of Mozilla engagement messaging

We are a ways out from nailing down the UX that encompasses everything I mentioned above, so I think placing this import option in Settings makes sense for now, with the longer term plan to roll it into a good, holistic first-run flow.
>I think placing this import option in Settings makes sense for now, with the 
>longer term plan to roll it into a good, holistic first-run flow.

If the user selects "Import bookmarks and history from Android" in the settings menu, should there be an additional confirmation dialog?
Yes, there should. Can we let them choose whether they want to import everything or just bookmarks / just history?





         +----------------------------------------------------+
         |                                                    |
         |  Import Bookmarks & History from Android           |
         |                                                    |
         +---------------------------------------------------->
         |                                                    |
         |                                                    |
         |                                       +---+        |
         |  Bookmarks                            | X |        |
         |                                       +---+        |
         |                                                    |
         |                                                    |
         |                                       +---+        |
         |  History                              | X |        |
         |                                       +---+        |
         |                                                    |
         |                                                    |
         +-------------------------+-------------------------->
         |                         |                          |
         |      Cancel             |        Import            |
         |                         |                          |
         +-------------------------+>-------------------------+
Closing as bug 710331 just landed.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Import from Android UI looks as in comment #8 on the latest Nightly build. Closing bug as verified fixed.

--
Firefox 19.0a1 (2012-10-16)
Device: Galaxy Note
OS: Android 4.0.4
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.