The default bug view has changed. See this FAQ.

-moz-transform causes box-shadow quirks

RESOLVED FIXED in Firefox 14

Status

()

Core
Layout
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: cvan, Assigned: jrmuizel)

Tracking

({regression})

15 Branch
mozilla15
x86_64
Mac OS X
regression
Points:
---

Firefox Tracking Flags

(firefox14 verified, firefox15 verified)

Details

Attachments

(4 attachments)

(Reporter)

Description

5 years ago
Created attachment 628052 [details]
-moz-transform and box-shadow not playing well (Nightly)

User agent:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:15.0) Gecko/15.0 Firefox/15.0a1

Test case:
http://jsfiddle.net/Wj64w/

Behaviour:
`-moz-transform: scalex(-1)` causes `box-shadow` styles to get clipped.
(Reporter)

Comment 1

5 years ago
Created attachment 628053 [details]
-moz-transform and box-shadow playing well (Firefox 12.0)
(Reporter)

Updated

5 years ago
Component: General → Layout
Product: Firefox → Core
QA Contact: general → layout
(Reporter)

Updated

5 years ago
Version: unspecified → 15 Branch
(Reporter)

Comment 2

5 years ago
Created attachment 628078 [details]
Test case

Comment 3

5 years ago
This regressed at a changeset that landed between May 22 and May 28, inclusive.
Keywords: regression, regressionwindow-wanted

Comment 4

5 years ago
This was caused by the landing of the patch in bug 757039.
https://hg.mozilla.org/mozilla-central/rev/dc8bae2d72e7

If we back that out, we should consider backing that out of aurora too, since it got uplifted to that branch.
Keywords: regressionwindow-wanted

Updated

5 years ago
Blocks: 757039

Comment 5

5 years ago
Ah, I misread the bug. It hasn't been uplifted to aurora yet. Scratch that last bit.
(Assignee)

Comment 6

5 years ago
Created attachment 628215 [details] [diff] [review]
Don't fast path negative scales

This should fix it
Assignee: nobody → jmuizelaar
Attachment #628215 - Flags: review?(roc)
Attachment #628215 - Flags: review?(roc) → review+

Comment 7

5 years ago
jrmuizel and roc, thanks for the quick fix and review! :)
(Assignee)

Comment 8

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b480a66acbc
(Assignee)

Comment 9

5 years ago
Comment on attachment 628215 [details] [diff] [review]
Don't fast path negative scales

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 757039
User impact if declined: Buggy shadow drawing with css transforms
Testing completed (on m-c, etc.): This is basically a partial revert of 757039
Risk to taking this patch (and alternatives if risky): Reduces the risk of taking 757039 because the new code is triggered in fewer cases.
String or UUID changes made by this patch:
Attachment #628215 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/6b480a66acbc
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Comment on attachment 628215 [details] [diff] [review]
Don't fast path negative scales

[Triage Comment]
Approved for Aurora 14. If this doesn't land in time for the merge this afternoon PT, please re-nominate for Beta approval.
Attachment #628215 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 12

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/57b91ddc54fc
(Assignee)

Updated

5 years ago
status-firefox14: --- → fixed
status-firefox15: --- → fixed

Comment 13

5 years ago
Hi guys.
I wanted to verify this bug and so I compared the test case between Firefox 15 beta 1 and Firefox 13 beta 6 and they are exactly the same.
Since is fixed in FX14 and 15, shouldn't the image be different in Firefox 13?

Thanks
(Assignee)

Comment 14

5 years ago
(In reply to Vlad [QA] from comment #13)
> Hi guys.
> I wanted to verify this bug and so I compared the test case between Firefox
> 15 beta 1 and Firefox 13 beta 6 and they are exactly the same.
> Since is fixed in FX14 and 15, shouldn't the image be different in Firefox
> 13?
> 
> Thanks

This was never released broken. It was broken and fixed before a release.

Comment 15

5 years ago
Considering comment 13 and 14, changing the flags to verified.
status-firefox14: fixed → verified
status-firefox15: fixed → verified
You need to log in before you can comment on or make changes to this bug.