Closed Bug 759457 Opened 10 years ago Closed 10 years ago
-moz-transform causes box-shadow quirks
9.93 KB, image/png
10.55 KB, image/png
211 bytes, text/html
976 bytes, patch
|Details | Diff | Splinter Review|
User agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:15.0) Gecko/15.0 Firefox/15.0a1 Test case: http://jsfiddle.net/Wj64w/ Behaviour: `-moz-transform: scalex(-1)` causes `box-shadow` styles to get clipped.
Component: General → Layout
Product: Firefox → Core
QA Contact: general → layout
This regressed at a changeset that landed between May 22 and May 28, inclusive.
This was caused by the landing of the patch in bug 757039. https://hg.mozilla.org/mozilla-central/rev/dc8bae2d72e7 If we back that out, we should consider backing that out of aurora too, since it got uplifted to that branch.
Ah, I misread the bug. It hasn't been uplifted to aurora yet. Scratch that last bit.
This should fix it
Assignee: nobody → jmuizelaar
Attachment #628215 - Flags: review?(roc)
Attachment #628215 - Flags: review?(roc) → review+
jrmuizel and roc, thanks for the quick fix and review! :)
Comment on attachment 628215 [details] [diff] [review] Don't fast path negative scales [Approval Request Comment] Bug caused by (feature/regressing bug #): 757039 User impact if declined: Buggy shadow drawing with css transforms Testing completed (on m-c, etc.): This is basically a partial revert of 757039 Risk to taking this patch (and alternatives if risky): Reduces the risk of taking 757039 because the new code is triggered in fewer cases. String or UUID changes made by this patch:
Attachment #628215 - Flags: approval-mozilla-aurora?
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Comment on attachment 628215 [details] [diff] [review] Don't fast path negative scales [Triage Comment] Approved for Aurora 14. If this doesn't land in time for the merge this afternoon PT, please re-nominate for Beta approval.
Attachment #628215 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Hi guys. I wanted to verify this bug and so I compared the test case between Firefox 15 beta 1 and Firefox 13 beta 6 and they are exactly the same. Since is fixed in FX14 and 15, shouldn't the image be different in Firefox 13? Thanks
(In reply to Vlad [QA] from comment #13) > Hi guys. > I wanted to verify this bug and so I compared the test case between Firefox > 15 beta 1 and Firefox 13 beta 6 and they are exactly the same. > Since is fixed in FX14 and 15, shouldn't the image be different in Firefox > 13? > > Thanks This was never released broken. It was broken and fixed before a release.
Considering comment 13 and 14, changing the flags to verified.
You need to log in before you can comment on or make changes to this bug.