759457 - -moz-transform causes box-shadow quirks

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Christopher Van Wiemeersch [:cvan]]

Attachment: -moz-transform and box-shadow not playing well (Nightly)

User agent:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:15.0) Gecko/15.0 Firefox/15.0a1

Test case:
http://jsfiddle.net/Wj64w/

Behaviour:
`-moz-transform: scalex(-1)` causes `box-shadow` styles to get clipped.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

Attachment: -moz-transform and box-shadow playing well (Firefox 12.0)

Comment 2

[Christopher Van Wiemeersch [:cvan]]

Attachment: Test case

Comment 3

[Frank Yan (:fryn)]

This regressed at a changeset that landed between May 22 and May 28, inclusive.

Comment 4

[Frank Yan (:fryn)]

This was caused by the landing of the patch in bug 757039.
https://hg.mozilla.org/mozilla-central/rev/dc8bae2d72e7

If we back that out, we should consider backing that out of aurora too, since it got uplifted to that branch.

Comment 5

[Frank Yan (:fryn)]

Ah, I misread the bug. It hasn't been uplifted to aurora yet. Scratch that last bit.

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Attachment: Don't fast path negative scales

This should fix it

Comment 7

[Frank Yan (:fryn)]

jrmuizel and roc, thanks for the quick fix and review! :)

Comment 8

[Jeff Muizelaar [:jrmuizel]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6b480a66acbc

Comment 9

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 628215 [details] [diff] [review]
Don't fast path negative scales

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 757039
User impact if declined: Buggy shadow drawing with css transforms
Testing completed (on m-c, etc.): This is basically a partial revert of 757039
Risk to taking this patch (and alternatives if risky): Reduces the risk of taking 757039 because the new code is triggered in fewer cases.
String or UUID changes made by this patch:

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6b480a66acbc

Comment 11

[Alex Keybl [:akeybl]]

Comment on attachment 628215 [details] [diff] [review]
Don't fast path negative scales

[Triage Comment]
Approved for Aurora 14. If this doesn't land in time for the merge this afternoon PT, please re-nominate for Beta approval.

Comment 12

[Jeff Muizelaar [:jrmuizel]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/57b91ddc54fc

Comment 13

[Vlad [QA]]

Hi guys.
I wanted to verify this bug and so I compared the test case between Firefox 15 beta 1 and Firefox 13 beta 6 and they are exactly the same.
Since is fixed in FX14 and 15, shouldn't the image be different in Firefox 13?

Thanks

Comment 14

[Jeff Muizelaar [:jrmuizel]]

(In reply to Vlad [QA] from comment #13)
> Hi guys.
> I wanted to verify this bug and so I compared the test case between Firefox
> 15 beta 1 and Firefox 13 beta 6 and they are exactly the same.
> Since is fixed in FX14 and 15, shouldn't the image be different in Firefox
> 13?
> 
> Thanks

This was never released broken. It was broken and fixed before a release.

Comment 15

[Vlad [QA]]

Considering comment 13 and 14, changing the flags to verified.