Closed Bug 757039 Opened 7 years ago Closed 7 years ago

Handle non-uniform scales when doing device space blurs

Categories

(Core :: Layout, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla15
Tracking Status
firefox14 --- fixed
firefox15 --- fixed
blocking-fennec1.0 --- soft

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

The Java screenshoting code draws pages at non-uniform scales. It's not much work to handle these so let's do it.
Blocks: 753028
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc8bae2d72e7
Assignee: nobody → jmuizelaar
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/dc8bae2d72e7
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Duplicate of this bug: 753028
Comment on attachment 625639 [details] [diff] [review]
Handle non-uniform scales when doing device space blurs

[Approval Request Comment]
User impact if declined: Very slow box-shadow in java screenshotting code and potential OOM. This is needed to make nonnompaelo.com usable.
Testing completed (on m-c, etc.): been on m-c for a while
Risk to taking this patch (and alternatives if risky): Some risk because it impacts desktop as well as mobile. Passes all our tests
String or UUID changes made by this patch: None
Attachment #625639 - Flags: approval-mozilla-aurora?
(In reply to Jeff Muizelaar [:jrmuizel] from comment #5)
> Risk to taking this patch (and alternatives if risky): Some risk because it
> impacts desktop as well as mobile. Passes all our tests

How should we be on the lookout for regressions here (both mobile and desktop) if approved?
rather, the question should be "where" can we expect to find regressions if they do occur?
(In reply to Alex Keybl [:akeybl] from comment #7)
> rather, the question should be "where" can we expect to find regressions if
> they do occur?

Shadow drawing
Depends on: 759457
Comment on attachment 625639 [details] [diff] [review]
Handle non-uniform scales when doing device space blurs

This caused a regression: bug 759457.
Attachment #625639 - Flags: approval-mozilla-aurora?
Comment on attachment 625639 [details] [diff] [review]
Handle non-uniform scales when doing device space blurs

Rerequesting aurora approval now that the regression fix has landed on inbound.
Attachment #625639 - Flags: approval-mozilla-aurora?
Dupe bug 753028 was marked as blocking-fennec1.0+, so setting it to ? here (I don't have access to + for some reason). Given the regression we found previously, let's give this some more bake time on m-c.
blocking-fennec1.0: --- → ?
Comment on attachment 625639 [details] [diff] [review]
Handle non-uniform scales when doing device space blurs

[Triage Comment]
approval to land on where ever 14 is now
Attachment #625639 - Flags: approval-mozilla-aurora? → approval-mozilla-beta+
We're opportunistically taking this, but we wouldn't block on it.
blocking-fennec1.0: ? → soft
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.