757039 - Handle non-uniform scales when doing device space blurs

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

The Java screenshoting code draws pages at non-uniform scales. It's not much work to handle these so let's do it.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Handle non-uniform scales when doing device space blurs

Comment 2

[Jeff Muizelaar [:jrmuizel]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dc8bae2d72e7

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/dc8bae2d72e7

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 625639 [details] [diff] [review]
Handle non-uniform scales when doing device space blurs

[Approval Request Comment]
User impact if declined: Very slow box-shadow in java screenshotting code and potential OOM. This is needed to make nonnompaelo.com usable.
Testing completed (on m-c, etc.): been on m-c for a while
Risk to taking this patch (and alternatives if risky): Some risk because it impacts desktop as well as mobile. Passes all our tests
String or UUID changes made by this patch: None

Comment 6

[Alex Keybl [:akeybl]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #5)
> Risk to taking this patch (and alternatives if risky): Some risk because it
> impacts desktop as well as mobile. Passes all our tests

How should we be on the lookout for regressions here (both mobile and desktop) if approved?

Comment 7

[Alex Keybl [:akeybl]]

rather, the question should be "where" can we expect to find regressions if they do occur?

Comment 8

[Jeff Muizelaar [:jrmuizel]]

(In reply to Alex Keybl [:akeybl] from comment #7)
> rather, the question should be "where" can we expect to find regressions if
> they do occur?

Shadow drawing

Comment 9

[Frank Yan (:fryn)]

Comment on attachment 625639 [details] [diff] [review]
Handle non-uniform scales when doing device space blurs

This caused a regression: bug 759457.

Comment 10

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 625639 [details] [diff] [review]
Handle non-uniform scales when doing device space blurs

Rerequesting aurora approval now that the regression fix has landed on inbound.

Comment 11

[Alex Keybl [:akeybl]]

Dupe bug 753028 was marked as blocking-fennec1.0+, so setting it to ? here (I don't have access to + for some reason). Given the regression we found previously, let's give this some more bake time on m-c.

Comment 12

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 625639 [details] [diff] [review]
Handle non-uniform scales when doing device space blurs

[Triage Comment]
approval to land on where ever 14 is now

Comment 13

[Joe Drew (not getting mail)]

We're opportunistically taking this, but we wouldn't block on it.

Comment 14

[Joe Drew (not getting mail)]

Ah, turns out this is already on beta: http://hg.mozilla.org/releases/mozilla-beta/rev/74f5e0d677f2