With toolbar.customization.usesheet=true, the customization document stays alive after closing the sheet

RESOLVED FIXED in Firefox 16

Status

()

Firefox
Toolbars and Customization
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 16
All
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 628338 [details] [diff] [review]
patch
Attachment #628338 - Flags: review?(ttaubert)
Why did you put the sheetFrame.setAttribute("src") after the sheetFrame.setAttribute("style")?
(Assignee)

Comment 2

5 years ago
Because adding the beforecustomization event listener before kicking off the loading reads nicer. It doesn't matter at all on a technical level.
(Assignee)

Updated

5 years ago
Blocks: 760083
(Assignee)

Updated

5 years ago
Attachment #628338 - Flags: review?(gavin.sharp)
Attachment #628338 - Flags: review?(ttaubert) → review+
(Assignee)

Updated

5 years ago
Attachment #628338 - Flags: review?(gavin.sharp)
(Assignee)

Comment 3

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/86350701d210
Target Milestone: --- → Firefox 16
https://hg.mozilla.org/mozilla-central/rev/86350701d210
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Blocks: 772885
You need to log in before you can comment on or make changes to this bug.