Clean up and consolidate toolbar customization tests

RESOLVED FIXED in Firefox 16

Status

()

Firefox
Toolbars and Customization
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 16
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 628702 [details] [diff] [review]
patch
Attachment #628702 - Flags: review?(ttaubert)
(Assignee)

Comment 1

5 years ago
Created attachment 628706 [details] [diff] [review]
patch

properly updated to mozilla-central tip
Attachment #628702 - Attachment is obsolete: true
Attachment #628702 - Flags: review?(ttaubert)
Attachment #628706 - Flags: review?(ttaubert)
Comment on attachment 628706 [details] [diff] [review]
patch

Review of attachment 628706 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/Makefile.in
@@ +264,4 @@
>  		$(NULL)
>  
>  # TODO: Activate after carbon test plugin lands, bug 628651
>  # 		browser_maconly_carbon_mismatch_plugin.js \

Nit: Can we activate this now that bug 628651 has been fixed?
Attachment #628706 - Flags: review?(ttaubert) → review+
(Assignee)

Comment 3

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/950c5e127ea4

(In reply to Tim Taubert [:ttaubert] from comment #2)
> >  # TODO: Activate after carbon test plugin lands, bug 628651
> >  # 		browser_maconly_carbon_mismatch_plugin.js \
> 
> Nit: Can we activate this now that bug 628651 has been fixed?

I'll push it to the tryserver.
Target Milestone: --- → Firefox 16
(Assignee)

Comment 4

5 years ago
> (In reply to Tim Taubert [:ttaubert] from comment #2)
> > >  # TODO: Activate after carbon test plugin lands, bug 628651
> > >  # 		browser_maconly_carbon_mismatch_plugin.js \
> > 
> > Nit: Can we activate this now that bug 628651 has been fixed?
> 
> I'll push it to the tryserver.

https://tbpl.mozilla.org/?tree=Try&rev=e40012c53783
https://hg.mozilla.org/mozilla-central/rev/950c5e127ea4
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Blocks: 772885
You need to log in before you can comment on or make changes to this bug.