Closed Bug 760083 Opened 11 years ago Closed 11 years ago

Clean up and consolidate toolbar customization tests

Categories

(Firefox :: Toolbars and Customization, defect)

Product:
Firefox
Component:
Toolbars and Customization
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 16

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

patch
15.40 KB, patch
ttaubert
: review+
Details | Diff | Splinter Review
Attached patch patch (obsolete) — — Splinter Review 
      No description provided.
Attachment #628702 - Flags: review?(ttaubert)
Attached patch patch — — Splinter Review 
properly updated to mozilla-central tip
Attachment #628702 - Attachment is obsolete: true
Attachment #628702 - Flags: review?(ttaubert)
Attachment #628706 - Flags: review?(ttaubert)
Comment on attachment 628706 [details] [diff] [review]
patch

Review of attachment 628706 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/Makefile.in
@@ +264,4 @@
>  		$(NULL)
>  
>  # TODO: Activate after carbon test plugin lands, bug 628651
>  # 		browser_maconly_carbon_mismatch_plugin.js \

Nit: Can we activate this now that bug 628651 has been fixed?
Attachment #628706 - Flags: review?(ttaubert) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/950c5e127ea4

(In reply to Tim Taubert [:ttaubert] from comment #2)
> >  # TODO: Activate after carbon test plugin lands, bug 628651
> >  # 		browser_maconly_carbon_mismatch_plugin.js \
> 
> Nit: Can we activate this now that bug 628651 has been fixed?

I'll push it to the tryserver.
Target Milestone: --- → Firefox 16
> (In reply to Tim Taubert [:ttaubert] from comment #2)
> > >  # TODO: Activate after carbon test plugin lands, bug 628651
> > >  # 		browser_maconly_carbon_mismatch_plugin.js \
> > 
> > Nit: Can we activate this now that bug 628651 has been fixed?
> 
> I'll push it to the tryserver.

https://tbpl.mozilla.org/?tree=Try&rev=e40012c53783
https://hg.mozilla.org/mozilla-central/rev/950c5e127ea4
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.