759825 - reenable testprofilepath

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Jeff Hammel]

the mutt test, testprofilepath.py, is currently disabled.  It should
be reenabled, especially since, unlike the mutt js tests, the python
tests actually pass.

Comment 1

[Jeff Hammel]

Attachment: reenable the test

The test works from the command line but does not work from mutt.  I suspect this is from the fact that mutt imports mozprocess and the default argument to env is os.environ.copy(), which is done at module import time.  Instead, it should be done at instance creation time

Comment 2

[Jeff Hammel]

Comment on attachment 628385 [details] [diff] [review]
reenable the test

You'll need the fix from bug 759840 for this to work.  Not sure if we should wait for a mozprocess version bump, etc,

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Jeff Hammel [:jhammel] from comment #2)
> You'll need the fix from bug 759840 for this to work.  Not sure if we should
> wait for a mozprocess version bump, etc,

Given that this test is in the mozmill repository we should do a version bump of mozprocess first, yes. Same for mozprofile (bug 758250) and any other package we depend on.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 628385 [details] [diff] [review]
reenable the test

Jeff, do we have any progress on bug 759916? Any this looks good. But it could be that the patch cannot be applied correctly anymore.

Comment 5

[Jeff Hammel]

I haven't had the chance to do bug 759916 last week.  I will do so when I have time free but as the close of Q2 looms I'm not sure when this is

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 628385 [details] [diff] [review]
reenable the test

We need a version bump of mozrunner together with this patch. If you don't mind I can do that quickly.

Comment 7

[Jeff Hammel]

Sounds good to me

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch (re-enable)

Pointer to Github pull-request

Comment 9

[Jeff Hammel]

Comment on attachment 631947 [details]
Patch (re-enable)

lgtm

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Pushed to master:
https://github.com/mozautomation/mozmill/commit/143568d7b54297e38755baa1b29bafdb31386e75