Closed
Bug 759906
Opened 12 years ago
Closed 12 years ago
Pass the applications' categories to Firefox
Categories
(Marketplace Graveyard :: General, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
2012-08-23
People
(Reporter: marco, Assigned: kngo)
References
Details
This is needed for the Linux installer. To add an entry in the applications menu in Linux, you need to know the category (at least on some desktop environments). This is the list of the categories in the freedesktop standard: http://standards.freedesktop.org/menu-spec/latest/apa.html We could add custom categories, so we could add the "WebApps" category. But this would create a difference between web applications and native applications.
Comment 1•12 years ago
|
||
What should we doing on the Marketplace side of things? Will there be a change to the navigator.mozApps API to allow a `category` to be passed? Is this a platform bug or Marketplace bug?
Reporter | ||
Comment 2•12 years ago
|
||
I don't know what the best solution would be, maybe a change to the mozApps API is better than a change in the manifest format. The marketplace knows the category of an application, so we wouldn't rely on developers to add this information in the manifest.
Reporter | ||
Comment 3•12 years ago
|
||
I've spoken with Anant, and he suggested to add the category of the application to install_data.
Comment 4•12 years ago
|
||
(In reply to Marco Castelluccio from comment #3) > I've spoken with Anant, and he suggested to add the category of the > application to install_data. 1) Is there a bug on the platform side of things (besides bug 744193) to extract the category from `install_data`? 2) Can you file a new bug (à la bug 747283) with suggested copy for the directions on how to launch apps after installation on Linux? Someone brought up an interesting idea that could work for Linux — https://bugzilla.mozilla.org/show_bug.cgi?id=747283#c9 — what do you think of that?
Reporter | ||
Comment 5•12 years ago
|
||
(In reply to Chris Van Wiemeersch [:cvan] from comment #4) > 1) Is there a bug on the platform side of things (besides bug 744193) to > extract the category from `install_data`? I've just filed bug 760748. > 2) Can you file a new bug (à la bug 747283) with suggested copy for the > directions on how to launch apps after installation on Linux? Someone > brought up an interesting idea that could work for Linux — > https://bugzilla.mozilla.org/show_bug.cgi?id=747283#c9 — what do you think > of that? I don't know what Opera does, I'll check tomorrow. However I think Opera widgets are far different from our native web apps. I've filed bug 760750.
Updated•12 years ago
|
Priority: -- → P3
Reporter | ||
Comment 6•12 years ago
|
||
Maybe the install_data solution is no longer feasible (see bug 711133).
Comment 7•12 years ago
|
||
What is the action on this bug?
Reporter | ||
Comment 8•12 years ago
|
||
https://bugzilla.mozilla.org/show_bug.cgi?id=711133#c20
Reporter | ||
Comment 9•12 years ago
|
||
So on the Marketplace side, we just need to pass the category (or categories) of the webapp through the install function. See bug 760748.
Updated•12 years ago
|
Assignee: nobody → ngoke
Target Milestone: --- → 2012-07-26
Assignee | ||
Comment 10•12 years ago
|
||
https://github.com/mozilla/zamboni/commit/73f32e56d6aff0d9cb476b5f853af5e1c99ab130
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 11•12 years ago
|
||
Has the patch already shipped on marketplace.mozilla.org? aParams here (http://mxr.mozilla.org/mozilla-central/source/dom/apps/src/Webapps.js#119) contains only the receipt if I install an application from the Marketplace.
Reporter | ||
Updated•12 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 12•12 years ago
|
||
Marco, what needs to change for this to work as expected?
Reporter | ||
Comment 13•12 years ago
|
||
The marketplace needs to pass the categories array just like it passes the receipts array.
Comment 14•12 years ago
|
||
Kevin, could you please take a look at this this week?
Target Milestone: 2012-07-26 → 2012-08-23
Assignee | ||
Comment 15•12 years ago
|
||
Marco: tell me if this works https://github.com/mozilla/zamboni/commit/b536d1a2463ddcb54d5f98ec0f2f9f342b233824
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 16•12 years ago
|
||
Thank you. I need to fix the Marketplace category names in the Firefox code, where can I find them?
Status: RESOLVED → VERIFIED
Comment 17•12 years ago
|
||
(In reply to Marco Castelluccio [:marco] from comment #16) > Thank you. I need to fix the Marketplace category names in the Firefox code, > where can I find them? What do you mean by this?
Reporter | ||
Comment 18•12 years ago
|
||
http://mxr.mozilla.org/mozilla-central/source/toolkit/webapps/WebappsInstaller.jsm#770 Here I assumed those names, are they correct? (I'll use toLowerCase to do the comparison, as the capital letters are wrong)
Reporter | ||
Comment 19•12 years ago
|
||
Ok, I assume they are correct. I've filed bug 796094.
You need to log in
before you can comment on or make changes to this bug.
Description
•