Last Comment Bug 796094 - Fix category names
: Fix category names
Product: Firefox Graveyard
Classification: Graveyard
Component: Web Apps (show other bugs)
: 17 Branch
: All Linux
-- normal
: Firefox 18
Assigned To: Marco Castelluccio [:marco]
: Jason Smith [:jsmith]
Depends on:
  Show dependency treegraph
Reported: 2012-10-01 13:03 PDT by Marco Castelluccio [:marco]
Modified: 2016-02-04 15:00 PST (History)
3 users (show)
ryanvm: in‑testsuite-
See Also:
QA Whiteboard:
Iteration: ---
Points: ---

Patch (1.01 KB, patch)
2012-10-01 13:03 PDT, Marco Castelluccio [:marco]
myk: review+
Details | Diff | Splinter Review
Patch v2 (1.03 KB, patch)
2012-10-06 04:47 PDT, Marco Castelluccio [:marco]
akeybl: approval‑mozilla‑beta+
Details | Diff | Splinter Review

Description User image Marco Castelluccio [:marco] 2012-10-01 13:03:05 PDT
Created attachment 666662 [details] [diff] [review]

A really simple fix for the category names.
Comment 1 User image Myk Melez [:myk] [@mykmelez] 2012-10-02 14:31:57 PDT
Comment on attachment 666662 [details] [diff] [review]

>+      if (translations[catLower])

Nit: `in` would be slightly more accurate, i.e.:

  if (catLower in translations)

>+        categories += translations[catLower] + ";";

Nit: the style guide says to "always brace controlled statements" <>.
Comment 2 User image Marco Castelluccio [:marco] 2012-10-06 04:47:03 PDT
Created attachment 668763 [details] [diff] [review]
Patch v2
Comment 3 User image Marco Castelluccio [:marco] 2012-10-06 06:52:14 PDT
Comment on attachment 668763 [details] [diff] [review]
Patch v2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Wrong assumption about Marketplace category names
User impact if declined: Webapps on Linux wouldn't be associated to the correct category
Testing completed (on m-c, etc.): Local testing. It's an extremely simple change.
Risk to taking this patch (and alternatives if risky): No risk.
String or UUID changes made by this patch: None
Comment 4 User image Ryan VanderMeulen [:RyanVM] 2012-10-06 19:04:51 PDT
Comment 5 User image Phil Ringnalda (:philor) 2012-10-07 12:22:40 PDT
Comment 6 User image Ryan VanderMeulen [:RyanVM] 2012-10-27 15:31:03 PDT

Note You need to log in before you can comment on or make changes to this bug.