Created attachment 666662 [details] [diff] [review] Patch A really simple fix for the category names.
Comment on attachment 666662 [details] [diff] [review] Patch >+ if (translations[catLower]) Nit: `in` would be slightly more accurate, i.e.: if (catLower in translations) >+ categories += translations[catLower] + ";"; Nit: the style guide says to "always brace controlled statements" <https://developer.mozilla.org/en-US/docs/Developer_Guide/Coding_Style?redirectlocale=en-US&redirectslug=Mozilla_Coding_Style_Guide#Control_Structures>.
Attachment #666662 - Flags: review?(myk) → review+
Created attachment 668763 [details] [diff] [review] Patch v2
Comment on attachment 668763 [details] [diff] [review] Patch v2 [Approval Request Comment] Bug caused by (feature/regressing bug #): Wrong assumption about Marketplace category names User impact if declined: Webapps on Linux wouldn't be associated to the correct category Testing completed (on m-c, etc.): Local testing. It's an extremely simple change. Risk to taking this patch (and alternatives if risky): No risk. String or UUID changes made by this patch: None
Attachment #668763 - Flags: approval-mozilla-aurora?
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Attachment #668763 - Flags: approval-mozilla-aurora? → approval-mozilla-beta+
status-firefox17: --- → fixed
status-firefox18: --- → fixed
You need to log in before you can comment on or make changes to this bug.