Closed Bug 796094 Opened 8 years ago Closed 8 years ago

Fix category names

Categories

(Firefox Graveyard :: Web Apps, defect)

17 Branch
All
Linux
defect
Not set
normal

Tracking

(firefox17 fixed, firefox18 fixed)

RESOLVED FIXED
Firefox 18
Tracking Status
firefox17 --- fixed
firefox18 --- fixed

People

(Reporter: marco, Assigned: marco)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
A really simple fix for the category names.
Attachment #666662 - Flags: review?(myk)
Attachment #666662 - Flags: review?(felipc)
Comment on attachment 666662 [details] [diff] [review]
Patch

>+      if (translations[catLower])

Nit: `in` would be slightly more accurate, i.e.:

  if (catLower in translations)

>+        categories += translations[catLower] + ";";

Nit: the style guide says to "always brace controlled statements" <https://developer.mozilla.org/en-US/docs/Developer_Guide/Coding_Style?redirectlocale=en-US&redirectslug=Mozilla_Coding_Style_Guide#Control_Structures>.
Attachment #666662 - Flags: review?(myk) → review+
Attached patch Patch v2Splinter Review
Assignee: nobody → mar.castelluccio
Attachment #666662 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #666662 - Flags: review?(felipc)
Keywords: checkin-needed
Comment on attachment 668763 [details] [diff] [review]
Patch v2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Wrong assumption about Marketplace category names
User impact if declined: Webapps on Linux wouldn't be associated to the correct category
Testing completed (on m-c, etc.): Local testing. It's an extremely simple change.
Risk to taking this patch (and alternatives if risky): No risk.
String or UUID changes made by this patch: None
Attachment #668763 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/c92dd43099e7
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Attachment #668763 - Flags: approval-mozilla-aurora? → approval-mozilla-beta+
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.