796094 - Fix category names

Status: RESOLVED FIXED

(Firefox Graveyard :: Web Apps, defect)

Description

[Marco Castelluccio [:marco]]

Attachment: Patch

A really simple fix for the category names.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 666662 [details] [diff] [review]
Patch

>+      if (translations[catLower])

Nit: `in` would be slightly more accurate, i.e.:

  if (catLower in translations)

>+        categories += translations[catLower] + ";";

Nit: the style guide says to "always brace controlled statements" <https://developer.mozilla.org/en-US/docs/Developer_Guide/Coding_Style?redirectlocale=en-US&redirectslug=Mozilla_Coding_Style_Guide#Control_Structures>.

Comment 2

[Marco Castelluccio [:marco]]

Attachment: Patch v2

Comment 3

[Marco Castelluccio [:marco]]

Comment on attachment 668763 [details] [diff] [review]
Patch v2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Wrong assumption about Marketplace category names
User impact if declined: Webapps on Linux wouldn't be associated to the correct category
Testing completed (on m-c, etc.): Local testing. It's an extremely simple change.
Risk to taking this patch (and alternatives if risky): No risk.
String or UUID changes made by this patch: None

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c92dd43099e7

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/c92dd43099e7

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d15dced2abd2