Created attachment 666662 [details] [diff] [review]
A really simple fix for the category names.
Comment on attachment 666662 [details] [diff] [review]
>+ if (translations[catLower])
Nit: `in` would be slightly more accurate, i.e.:
if (catLower in translations)
>+ categories += translations[catLower] + ";";
Nit: the style guide says to "always brace controlled statements" <https://developer.mozilla.org/en-US/docs/Developer_Guide/Coding_Style?redirectlocale=en-US&redirectslug=Mozilla_Coding_Style_Guide#Control_Structures>.
Created attachment 668763 [details] [diff] [review]
Comment on attachment 668763 [details] [diff] [review]
[Approval Request Comment]
Bug caused by (feature/regressing bug #): Wrong assumption about Marketplace category names
User impact if declined: Webapps on Linux wouldn't be associated to the correct category
Testing completed (on m-c, etc.): Local testing. It's an extremely simple change.
Risk to taking this patch (and alternatives if risky): No risk.
String or UUID changes made by this patch: None