760090 - Find in Page buttons should have tap-down graphic assets

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Currently the buttons dont have a button tap-down graphic assets because it looks like you're not really pressing them.

Tested via 

Samsung Galaxy Nexus (Android 4.0.4)
20120531040223
http://hg.mozilla.org/integration/mozilla-inbound/rev/ff2ad97929e8

Comment 1

[:Margaret Leibovic]

Ian, thoughts?

Comment 2

[Alex Keybl [:akeybl]]

Will decide on tracking once UX has weighed in.

Comment 3

[Ian Barlow (:ibarlow)]

We do want tap-down background graphics here, and they should be orange -- for those who do not yet know, we are moving to a universal orange selection colour on all versions of Android.  

Adding Sriram, who has been orangifying our title bars and menus -- hopefully we can reuse some of those assets here. This would bee a good time to switch the search bar focus colour over to orange, as well.

Comment 4

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This reuses existing resource as background.

Comment 5

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/5b1e6a274426

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5b1e6a274426

Per the tree rules, please set the target milestone, assignee, etc when landing on inbound.

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Tracking for 15, please nominate for uplift to Aurora.

Comment 8

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 631279 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: The button won't have a highlight on press.
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): 
String or UUID changes made by this patch:

Comment 9

[Sriram Ramasubramanian [:sriram]]

Pushed to aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/498d69d70ada

Comment 10

[Cristian Nicolae (:xti)]

Find in Page buttons are having now the tap-down graphic assets both on Aurora and Nightly. The tap background is orange. 
Closing bug as verified fixed on:

Firefox 16.0a1 (2012-07-10)
Firefox 15.0a2 (2012-07-10)

Device: Galaxy Nexus
OS: Android 4.0.4