760187 - Phone URL bar should have softer texture

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sriram Ramasubramanian [:sriram]]

As a part of bug 758804, a more softer texture was added to the backgrounds. The phone UI should have the resources replaced for the url-bar to feel in place.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This patch changes the URL bar resources to match the new texture.

Few resources need change by ibarlow, as they have weird black edges. I'll push the patch with those changes.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 628918 [details] [diff] [review]
Patch

I am OK with replacing the images, but let's try to make the textures as small as apossible

Comment 3

[Sriram Ramasubramanian [:sriram]]

Pushed after replacing the resources:
One extra line changed in browser_toolbar to accommodate the perfect size of the plus button.
http://hg.mozilla.org/integration/mozilla-inbound/rev/b7fb3d52c843

Comment 4

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/mozilla-central/rev/b7fb3d52c843

Comment 5

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 628918 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): -
User impact if declined: 
There will be a visual clutter on phones due to difference in texture between the url-bar and about:home page.
Testing completed (on m-c, etc.): 06/05
Risk to taking this patch (and alternatives if risky): None
String or UUID changes made by this patch: -

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 628918 [details] [diff] [review]
Patch

no risk, approved.

Comment 7

[Sriram Ramasubramanian [:sriram]]

Pushed to aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/3b77c47e1c58