760196 - "Find in page" menu item missing in tablets

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sriram Ramasubramanian [:sriram]]

"Find in page" menu item is missing for tablets.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

The menu item is now added for tablets.

Comment 2

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/6a232df5e065

Comment 3

[Matt Brubeck (:mbrubeck)]

Sorry, this was backed out along with bug 739412 because it may have caused startup crashes related to mysterious missing drawable resources:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa02228ce9ab

Comment 4

[Sriram Ramasubramanian [:sriram]]

Pushed again:
http://hg.mozilla.org/integration/mozilla-inbound/rev/2caac347f963

Comment 5

[Gian-Carlo Pascutto [:gcp]]

Without this fix there's a startup crash on tablets, so setting tracking flag.

E/GeckoAppShell( 6890): >>> REPORTING UNCAUGHT EXCEPTION FROM THREAD 1 ("main")
E/GeckoAppShell( 6890): java.lang.NullPointerException
E/GeckoAppShell( 6890): 	at org.mozilla.gecko.GeckoApp.onPrepareOptionsMenu(GeckoApp.java:418)
E/GeckoAppShell( 6890): 	at android.app.Activity.onPreparePanel(Activity.java:2413)
E/GeckoAppShell( 6890): 	at com.android.internal.policy.impl.PhoneWindow.preparePanel(PhoneWindow.java:384)
E/GeckoAppShell( 6890): 	at com.android.internal.policy.impl.PhoneWindow.invalidatePanelMenu(PhoneWindow.java:668)
E/GeckoAppShell( 6890): 	at com.android.internal.policy.impl.PhoneWindow$2.run(PhoneWindow.java:2733)
E/GeckoAppShell( 6890): 	at android.os.Handler.handleCallback(Handler.java:587)
E/GeckoAppShell( 6890): 	at android.os.Handler.dispatchMessage(Handler.java:92)
E/GeckoAppShell( 6890): 	at android.os.Looper.loop(Looper.java:132)
E/GeckoAppShell( 6890): 	at android.app.ActivityThread.main(ActivityThread.java:4126)
E/GeckoAppShell( 6890): 	at java.lang.reflect.Method.invokeNative(Native Method)
E/GeckoAppShell( 6890): 	at java.lang.reflect.Method.invoke(Method.java:491)
E/GeckoAppShell( 6890): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:844)
E/GeckoAppShell( 6890): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:602)
E/GeckoAppShell( 6890): 	at dalvik.system.NativeStart.main(Native Method)

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2caac347f963

Comment 7

[Andreea Pod]

Verified fixed on:
-build: Firefox for Android 22.0a1 (2013-02-20)
-device: Asus Transformers TF101
-OS: Android 4.0.3