Closed
Bug 760196
Opened 12 years ago
Closed 12 years ago
"Find in page" menu item missing in tablets
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 15
People
(Reporter: sriram, Assigned: sriram)
References
Details
(Whiteboard: [tablet])
Attachments
(1 file)
2.08 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
"Find in page" menu item is missing for tablets.
Updated•12 years ago
|
OS: Mac OS X → Android
Hardware: x86 → ARM
Assignee | ||
Comment 1•12 years ago
|
||
The menu item is now added for tablets.
Assignee: nobody → sriram
Attachment #628809 -
Flags: review?(mark.finkle)
Updated•12 years ago
|
Attachment #628809 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 2•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/6a232df5e065
Comment 3•12 years ago
|
||
Sorry, this was backed out along with bug 739412 because it may have caused startup crashes related to mysterious missing drawable resources: https://hg.mozilla.org/integration/mozilla-inbound/rev/aa02228ce9ab
Assignee | ||
Comment 4•12 years ago
|
||
Pushed again: http://hg.mozilla.org/integration/mozilla-inbound/rev/2caac347f963
Comment 5•12 years ago
|
||
Without this fix there's a startup crash on tablets, so setting tracking flag. E/GeckoAppShell( 6890): >>> REPORTING UNCAUGHT EXCEPTION FROM THREAD 1 ("main") E/GeckoAppShell( 6890): java.lang.NullPointerException E/GeckoAppShell( 6890): at org.mozilla.gecko.GeckoApp.onPrepareOptionsMenu(GeckoApp.java:418) E/GeckoAppShell( 6890): at android.app.Activity.onPreparePanel(Activity.java:2413) E/GeckoAppShell( 6890): at com.android.internal.policy.impl.PhoneWindow.preparePanel(PhoneWindow.java:384) E/GeckoAppShell( 6890): at com.android.internal.policy.impl.PhoneWindow.invalidatePanelMenu(PhoneWindow.java:668) E/GeckoAppShell( 6890): at com.android.internal.policy.impl.PhoneWindow$2.run(PhoneWindow.java:2733) E/GeckoAppShell( 6890): at android.os.Handler.handleCallback(Handler.java:587) E/GeckoAppShell( 6890): at android.os.Handler.dispatchMessage(Handler.java:92) E/GeckoAppShell( 6890): at android.os.Looper.loop(Looper.java:132) E/GeckoAppShell( 6890): at android.app.ActivityThread.main(ActivityThread.java:4126) E/GeckoAppShell( 6890): at java.lang.reflect.Method.invokeNative(Native Method) E/GeckoAppShell( 6890): at java.lang.reflect.Method.invoke(Method.java:491) E/GeckoAppShell( 6890): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:844) E/GeckoAppShell( 6890): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:602) E/GeckoAppShell( 6890): at dalvik.system.NativeStart.main(Native Method)
Severity: normal → critical
tracking-fennec: --- → ?
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2caac347f963
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
Updated•12 years ago
|
Whiteboard: [tablet]
Comment 7•12 years ago
|
||
Verified fixed on: -build: Firefox for Android 22.0a1 (2013-02-20) -device: Asus Transformers TF101 -OS: Android 4.0.3
Status: RESOLVED → VERIFIED
Updated•11 years ago
|
tracking-fennec: ? → ---
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•