"Find in page" menu item missing in tablets

VERIFIED FIXED in Firefox 15

Status

()

defect
--
critical
VERIFIED FIXED
7 years ago
3 years ago

People

(Reporter: sriram, Assigned: sriram)

Tracking

unspecified
Firefox 15
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [tablet])

Attachments

(1 attachment)

"Find in page" menu item is missing for tablets.
Blocks: find
OS: Mac OS X → Android
Hardware: x86 → ARM
Posted patch PatchSplinter Review
The menu item is now added for tablets.
Assignee: nobody → sriram
Attachment #628809 - Flags: review?(mark.finkle)
Attachment #628809 - Flags: review?(mark.finkle) → review+
Depends on: 760223
Sorry, this was backed out along with bug 739412 because it may have caused startup crashes related to mysterious missing drawable resources:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa02228ce9ab
Without this fix there's a startup crash on tablets, so setting tracking flag.

E/GeckoAppShell( 6890): >>> REPORTING UNCAUGHT EXCEPTION FROM THREAD 1 ("main")
E/GeckoAppShell( 6890): java.lang.NullPointerException
E/GeckoAppShell( 6890): 	at org.mozilla.gecko.GeckoApp.onPrepareOptionsMenu(GeckoApp.java:418)
E/GeckoAppShell( 6890): 	at android.app.Activity.onPreparePanel(Activity.java:2413)
E/GeckoAppShell( 6890): 	at com.android.internal.policy.impl.PhoneWindow.preparePanel(PhoneWindow.java:384)
E/GeckoAppShell( 6890): 	at com.android.internal.policy.impl.PhoneWindow.invalidatePanelMenu(PhoneWindow.java:668)
E/GeckoAppShell( 6890): 	at com.android.internal.policy.impl.PhoneWindow$2.run(PhoneWindow.java:2733)
E/GeckoAppShell( 6890): 	at android.os.Handler.handleCallback(Handler.java:587)
E/GeckoAppShell( 6890): 	at android.os.Handler.dispatchMessage(Handler.java:92)
E/GeckoAppShell( 6890): 	at android.os.Looper.loop(Looper.java:132)
E/GeckoAppShell( 6890): 	at android.app.ActivityThread.main(ActivityThread.java:4126)
E/GeckoAppShell( 6890): 	at java.lang.reflect.Method.invokeNative(Native Method)
E/GeckoAppShell( 6890): 	at java.lang.reflect.Method.invoke(Method.java:491)
E/GeckoAppShell( 6890): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:844)
E/GeckoAppShell( 6890): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:602)
E/GeckoAppShell( 6890): 	at dalvik.system.NativeStart.main(Native Method)
Severity: normal → critical
tracking-fennec: --- → ?
https://hg.mozilla.org/mozilla-central/rev/2caac347f963
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
Blocks: 760357
Whiteboard: [tablet]
Verified fixed on:
-build: Firefox for Android 22.0a1 (2013-02-20)
-device: Asus Transformers TF101
-OS: Android 4.0.3
Status: RESOLVED → VERIFIED
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.