760226 - Remove unneeded EGLContext creation in GLController.java

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

This is old and causing some sadness on platforms with a limited number of contexts

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Don't create an egl context we don't use

Note, there's a small behaviour change which causes us to call onSurfaceChanged even when mGL would've been NULL. In this case it should be safe and this should be cleaned up after kat's work in bug 758635.

Comment 2

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/51d438f92407

Comment 3

[Joe Drew (not getting mail)]

Blocking because this fixed bug 754257.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 628898 [details] [diff] [review]
Don't create an egl context we don't use

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: We use an extra EGL context which is a problem for mobile devices with only 8 available contexts. Bug 754257 (a blocker) depends on this.
Testing completed (on m-c, etc.): Has been on m-c for a couple of days
Risk to taking this patch (and alternatives if risky): Mobile only, mostly removes some basically unused code.
String or UUID changes made by this patch: None

Comment 6

[Joe Drew (not getting mail)]

Comment on attachment 628898 [details] [diff] [review]
Don't create an egl context we don't use

This is already on aurora (mozilla15). Approved for beta, please land ASAP.

Comment 7

[Joe Drew (not getting mail)]

http://hg.mozilla.org/releases/mozilla-beta/rev/58b048bf961c

Comment 8

[Joe Drew (not getting mail)]

Backed out of beta for burning the tree. This needs to be pushed along with bug 757944, which I should have noticed from the Depends line.

https://hg.mozilla.org/releases/mozilla-beta/rev/8a0592b3f4ff

Comment 9

[Joe Drew (not getting mail)]

Relanded with bug 757944:

https://hg.mozilla.org/releases/mozilla-beta/rev/092b84e7cd64