Closed Bug 760302 Opened 12 years ago Closed 12 years ago

Support isempty and isnotempty operators for boolean charts

Categories

(bugzilla.mozilla.org :: General, enhancement)

Production
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dkl, Assigned: dkl)

Details

Attachments

(1 file)

Since this will probably be best as a BMO customization as 4.2 is completely different search-wise, I will create a patch on this bug instead of upstream. For the time being this simple patch should help a little with people needed to look for NULL or '' values for certain fields in BMO. This will need to be revised for 4.2 and I will work on a different patch for that version.

dkl
Attachment #628924 - Flags: review?(glob)
Comment on attachment 628924 [details] [diff] [review]
Patch to add isempty and isnotempty operator for boolean charts (v1)

Review of attachment 628924 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

nice :)

::: template/en/default/search/boolean-charts.html.tmpl
@@ +47,4 @@
>    "changedby",
>    "matches",
>    "notmatches",
> +  "isempty",  

nit: remove trailing spaces
Attachment #628924 - Flags: review?(glob) → review+
Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.0
modified Bugzilla/Search.pm
modified template/en/default/list/list.html.tmpl
modified template/en/default/search/boolean-charts.html.tmpl
modified template/en/default/global/field-descs.none.tmpl
Committed revision 8205.

thanks dkl
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
the upstream bug is bug 345194.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: