Closed Bug 76069 Opened 24 years ago Closed 24 years ago

ftp bookmarks no longer autoexpand

Categories

(SeaMonkey :: Bookmarks & History, defect)

Product:
SeaMonkey
Component:
Bookmarks & History
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9

People

(Reporter: bbaetz, Assigned: bbaetz)

Details

(Keywords: regression)

Attachments

(1 file)

patch
1.45 KB, patch
Details | Diff | Splinter Review
dougt's dirviewer checkin (which I reviewed) broke bookmarks urls - the initialisation which happens in the first OnStartRequest shouldn't happen if we aren't initialised through the xul document. As well, we shouldn't be reporting as an nsIFTPEventSink if we're not going to have somewhere to put the data (this removes the assertions caused by the NS_ENSURE at the top of that function) Patch coming up
Attached patch patch — — Splinter Review
Status: NEW → ASSIGNED
Keywords: patch, regression, review
err, forgot to ask: dougt, can I get a review waterson, sr please?
sr=waterson if dougt's okay with it.
You can remove mBindToGlobalObject. I don't think that we need it.
No, we need that, because that part needs to run only once, but we can't clear the mContainer like it used to because its needed for your ftp logging stuff.
Target Milestone: --- → mozilla0.9
r=dougt.
Component: XP Apps: GUI Features → Bookmarks
QA Contact: sairuh → claudius
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
See also bug 76618, IE favorites shown as a single bookmark.
VERIFIED Fixed with 2001042508 linux build -modulo other problems with dispalying the link as a folder in the first place. The core functionality works and can be verified in the personal toolbar and the bookmarks menubutton on the personal toolbar.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: