76618 - IE favorites shown as a single bookmark in manager/menu

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect, P1)

Description

[Jesse Ruderman]

In 2001 041804 Win98, the "Imported IE Favorites" folder is shown as a single 
bookmark.  Clicking on that bookmark does nothing.  0.9 blocker?

May be related to bug 76069, "ftp bookmarks no longer autoexpand" (fixed).

(On a side note, the bookmarks menu opens in ~0.3 seconds instead of ~3 seconds 
in today's build.  Does that mean the IE favorites are normally read before the 
bookmarks menu is shown?)

Comment 1

[Bradley Baetz]

Could be related. I don't have a windows build environment. dougt, is this
related to your change?

Comment 2

[Bradley Baetz]

Actually, I take that back. I thought that I had duplicated it with localsearch:
bookmarks (and hit breakpoints in nsDirectoryViewer.cpp!), but I hadn't. Sorry.

Comment 3

[Jesse Ruderman]

Filed bug 76676, "ie favorites should not be read until needed", for the 
bookmarks menu taking so long to appear in builds where importing IE Favorites 
isn't broken.

Comment 4

[Jesse Ruderman]

If other people are seeing this bug, it should be a mozilla0.9 blocker.  (I 
don't use this feature and I don't mind the bookmarks menu opening quickly, but 
I'm sure other people do use it.)

Comment 5

[Matthias Versen [:Matti]]

I see this on win2k build 20010424.. (CVS)
I see the "Imported IE Favorites" as a normal bookmark.
But I see it as a folder if I open the Bookmarks link on my personal toolbar.

Comment 6

[Claudius Gayle]

I've verified the following behavior with current builds (2001042508) on Mac, Win98, and
Linux:

All extended data folders e.g. IE Favorites and bookmarked ftp sites are not displaying
correctly in the Manage Bookmarks window and the toplevel bookmarks menu - they
display as single links instead of folders. *Note they appear correctly on the personal
toolbar, whether directly on the toolbar or accessed via the bookmarks button on the
ptoolbar.

Comment 7

[Aleksander Adamowski]

Confirming on win2k build 2001042908

I see the "Imported IE Favorites" as a normal bookmark in Bookmarks menu and I
see it as a folder if I open the Bookmarks link on my personal toolbar.

Comment 8

[Viswanath Ramachandran]

nav triage: we cant ship beta with this bug. 

Comment 9

[Doug Turner (:dougt)]

Is there a bug about how none of the imported bookmarks even work?  If I click 
on any of the bookmarked links, nothing happens... :-(

Comment 10

[Doug Turner (:dougt)]

actually, i see this content:

[InternetShortcut]
URL=http://www.microsoft.com/isapi/redir.dll?prd=windows&sbp=mediaplayer&plcid=&
pver=5.2&os=&over=&olcid=&clcid=&ar=Media&sba=Showcase&o1=&o2=&o3=
Modified=D04F4C0A7B65C00116


something broke bookmarks from resolving this shortcut.

Comment 11

[Bradley Baetz]

dougt: You broke the ftp ones, with the change to html content. I have plans to
fix that, maybe, as part of bug 78148.

I remember asking Ben about this bug, and he admitted possibly breaking it (this
was just after one of his landings). Something to do with removing one of the
rdf datasources, IIRC.

Comment 12

[timeless]

Dougt, yes there are lots of bugs filed for these regressions (people must 
really use the features i guess).

Comment 13

[ratman]

so much for 0.9 blocker.  

using win32 installer m0.9 - although the menubar bookmarks menu displays only a
non-active single bookmark for imported ie "favorites", the personal toolbar
bookmarks folder displays a correctly functioning imported ie favorites *folder*.

in addition, all other imported ie favorite subfolders previously copied from ie
favorites into the main bookmarks tree display as single bookmarks without
titles; clicking on them opens the file:// structure at the relevant location. 
the personal toolbar bookmarks folder, however, displays copied subdirectories
just fine.

the latter issue is more for bug 69768, but i thought it might be relevant.

Comment 14

[Ben Goodger (use ben at mozilla dot org for email)]

fixed. 

Comment 15

[Matthias Versen [:Matti]]

*** Bug 79669 has been marked as a duplicate of this bug. ***

Comment 16

[Claudius Gayle]

This bug is VERIFIED Fixed. I've changed the summary because I lumped other extended data
folders in with this because they were showingthe smae exact behavior and I imagined they are
all realy the same thing since the IE favs folder is really just a file:// link. Anyway, it is now fixed
but the other extendded data view are not (e.g. ftp:// folders). So now i'm going to file a new bug
just for those.
fixed in 20010511 builds

Comment 17

[Claudius Gayle]

filed bug 80401 for the ftp:// case.