760724 - Reader Mode: Update all icons in the URL bar and awesome screen

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Lucas Rocha (:lucasr)]

Ian: "Here are some updated icons for the urlbar, to make the lock, stop/go/search, and reader mode icons feel more in line. Please replace all of these at the same time. http://cl.ly/3O42022J1H0N2E1Y3K11 "

Comment 1

[Ian Barlow (:ibarlow)]

Lucas, FYI I just checked the zip file and everything you should need is already in there for the URL bar. 

It includes:
* Search icon
* Stop icon
* Go icon
* Lock icons (green and blue)
* Reader mode icon

Comment 2

[Sriram Ramasubramanian [:sriram]]

drawable-xlarge-*/ and drawable-sw600dp-*/ are the same resources.
Probably we can file a bug to make this duplication in Makefile directly (like create appropriate folders and copy stuff from drawable-xlarge-*/ )

Comment 3

[Lucas Rocha (:lucasr)]

Here's a summary of what I've done with the icons:

M mobile/android/base/Makefile.in
M mobile/android/base/resources/drawable-hdpi/ic_awesomebar_go.png
M mobile/android/base/resources/drawable-hdpi/ic_awesomebar_search.png
M mobile/android/base/resources/drawable-hdpi/reader.png
M mobile/android/base/resources/drawable-hdpi/site_security_identified.png
M mobile/android/base/resources/drawable-hdpi/site_security_verified.png
M mobile/android/base/resources/drawable-hdpi/urlbar_stop.png
M mobile/android/base/resources/drawable-land-hdpi-v14/ic_awesomebar_go.png
M mobile/android/base/resources/drawable-land-hdpi-v14/ic_awesomebar_search.png
M mobile/android/base/resources/drawable-land-hdpi-v14/site_security_identified.png
M mobile/android/base/resources/drawable-land-hdpi-v14/site_security_verified.png
M mobile/android/base/resources/drawable-land-hdpi-v14/urlbar_stop.png
M mobile/android/base/resources/drawable-land-mdpi-v14/ic_awesomebar_go.png
M mobile/android/base/resources/drawable-land-mdpi-v14/ic_awesomebar_search.png
M mobile/android/base/resources/drawable-land-mdpi-v14/site_security_identified.png
M mobile/android/base/resources/drawable-land-mdpi-v14/site_security_verified.png
M mobile/android/base/resources/drawable-land-mdpi-v14/urlbar_stop.png
M mobile/android/base/resources/drawable-land-xhdpi-v14/ic_awesomebar_go.png
M mobile/android/base/resources/drawable-land-xhdpi-v14/ic_awesomebar_search.png
M mobile/android/base/resources/drawable-land-xhdpi-v14/site_security_identified.png
M mobile/android/base/resources/drawable-land-xhdpi-v14/site_security_verified.png
M mobile/android/base/resources/drawable-land-xhdpi-v14/urlbar_stop.png
M mobile/android/base/resources/drawable-sw600dp-hdpi/urlbar_stop.png
M mobile/android/base/resources/drawable-sw600dp-mdpi/urlbar_stop.png
M mobile/android/base/resources/drawable-sw600dp-xhdpi/urlbar_stop.png
M mobile/android/base/resources/drawable-xhdpi-v11/ic_awesomebar_go.png
M mobile/android/base/resources/drawable-xhdpi-v11/ic_awesomebar_search.png
M mobile/android/base/resources/drawable-xhdpi-v11/reader.png
M mobile/android/base/resources/drawable-xhdpi-v11/site_security_identified.png
M mobile/android/base/resources/drawable-xhdpi-v11/site_security_verified.png
M mobile/android/base/resources/drawable-xhdpi-v11/urlbar_stop.png
M mobile/android/base/resources/drawable-xlarge-hdpi/urlbar_stop.png
M mobile/android/base/resources/drawable-xlarge-mdpi/urlbar_stop.png
M mobile/android/base/resources/drawable-xlarge-xhdpi/urlbar_stop.png
M mobile/android/base/resources/drawable/ic_awesomebar_go.png
M mobile/android/base/resources/drawable/ic_awesomebar_search.png
M mobile/android/base/resources/drawable/reader.png
M mobile/android/base/resources/drawable/site_security_identified.png
M mobile/android/base/resources/drawable/site_security_verified.png
M mobile/android/base/resources/drawable/urlbar_stop.png
A mobile/android/base/resources/drawable-land-hdpi-v14/reader.png
A mobile/android/base/resources/drawable-land-mdpi-v14/reader.png
A mobile/android/base/resources/drawable-land-xhdpi-v14/reader.png
A mobile/android/base/resources/drawable-sw600dp-hdpi/ic_awesomebar_go.png
A mobile/android/base/resources/drawable-sw600dp-hdpi/ic_awesomebar_search.png
A mobile/android/base/resources/drawable-sw600dp-hdpi/reader.png
A mobile/android/base/resources/drawable-sw600dp-hdpi/site_security_identified.png
A mobile/android/base/resources/drawable-sw600dp-hdpi/site_security_verified.png
A mobile/android/base/resources/drawable-sw600dp-mdpi/ic_awesomebar_go.png
A mobile/android/base/resources/drawable-sw600dp-mdpi/ic_awesomebar_search.png
A mobile/android/base/resources/drawable-sw600dp-mdpi/reader.png
A mobile/android/base/resources/drawable-sw600dp-mdpi/site_security_identified.png
A mobile/android/base/resources/drawable-sw600dp-mdpi/site_security_verified.png
A mobile/android/base/resources/drawable-sw600dp-xhdpi/ic_awesomebar_go.png
A mobile/android/base/resources/drawable-sw600dp-xhdpi/ic_awesomebar_search.png
A mobile/android/base/resources/drawable-sw600dp-xhdpi/reader.png
A mobile/android/base/resources/drawable-sw600dp-xhdpi/site_security_identified.png
A mobile/android/base/resources/drawable-sw600dp-xhdpi/site_security_verified.png
A mobile/android/base/resources/drawable-xlarge-hdpi/ic_awesomebar_go.png
A mobile/android/base/resources/drawable-xlarge-hdpi/ic_awesomebar_search.png
A mobile/android/base/resources/drawable-xlarge-hdpi/reader.png
A mobile/android/base/resources/drawable-xlarge-hdpi/site_security_identified.png
A mobile/android/base/resources/drawable-xlarge-hdpi/site_security_verified.png
A mobile/android/base/resources/drawable-xlarge-mdpi/ic_awesomebar_go.png
A mobile/android/base/resources/drawable-xlarge-mdpi/ic_awesomebar_search.png
A mobile/android/base/resources/drawable-xlarge-mdpi/reader.png
A mobile/android/base/resources/drawable-xlarge-mdpi/site_security_identified.png
A mobile/android/base/resources/drawable-xlarge-mdpi/site_security_verified.png
A mobile/android/base/resources/drawable-xlarge-xhdpi/ic_awesomebar_go.png
A mobile/android/base/resources/drawable-xlarge-xhdpi/ic_awesomebar_search.png
A mobile/android/base/resources/drawable-xlarge-xhdpi/reader.png
A mobile/android/base/resources/drawable-xlarge-xhdpi/site_security_identified.png
A mobile/android/base/resources/drawable-xlarge-xhdpi/site_security_verified.png

Comment 4

[Lucas Rocha (:lucasr)]

Attachment: Update all icons in the URL bar and awesome screen

That makes all icons in awesomebar and toolbar have the same number of sizes/version than the stop button.

Comment 5

[Lucas Rocha (:lucasr)]

(In reply to Sriram Ramasubramanian [:sriram] from comment #2)
> drawable-xlarge-*/ and drawable-sw600dp-*/ are the same resources.
> Probably we can file a bug to make this duplication in Makefile directly
> (like create appropriate folders and copy stuff from drawable-xlarge-*/ )

Filed bug 763566 to track this.

Comment 6

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 631940 [details] [diff] [review]
Update all icons in the URL bar and awesome screen

Review of attachment 631940 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 7

[Lucas Rocha (:lucasr)]

Pushed: http://hg.mozilla.org/integration/mozilla-inbound/rev/6cced69f7fb6

Comment 8

[Lucas Rocha (:lucasr)]

Comment on attachment 631940 [details] [diff] [review]
Update all icons in the URL bar and awesome screen

Part of Reader Mode effort, also improves coverage of several icons for different screen sizes and densities.

Comment 9

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/6cced69f7fb6

Comment 10

[Alex Keybl [:akeybl]]

Comment on attachment 631940 [details] [diff] [review]
Update all icons in the URL bar and awesome screen

[Triage Comment]
Reader mode is not slated for FF15 in the current draft of the product roadmap.

Comment 11

[Alex Keybl [:akeybl]]

Comment on attachment 631940 [details] [diff] [review]
Update all icons in the URL bar and awesome screen

[Triage Comment]
Just an image swap (and addition). Low risk - approved for Beta 15.

Comment 12

[Alex Keybl [:akeybl]]

Forgot to mention that landing 7" tablet support was the main driver for approving.

Comment 13

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1e40ce5ba08b

Comment 14

[Lucas Rocha (:lucasr)]

Alex, Sriram, doesn't it have to land in Aurora as well?

Comment 15

[Scoobidiver (away)]

(In reply to Lucas Rocha (:lucasr) from comment #14)
> Alex, Sriram, doesn't it have to land in Aurora as well?
It landed in Nightly 16 (see Target Milestone).

Comment 16

[Sriram Ramasubramanian [:sriram]]

I believe it's in aurora as a part of the merge that happened. This patch wasn't there in beta alone.