760747 - Wrong check in Mac and Windows webapp runtimes

Status: VERIFIED FIXED

(Firefox Graveyard :: Webapp Runtime, defect, P2)

Description

[Marco Castelluccio [:marco]]

> rv = XRE_GetFileFromPath(rtIniPath, getter_AddRefs(rtINI));
> NS_ENSURE_SUCCESS(rv, false);
> 
> if (!rtINI) {

Something similar is in the Mac runtime. We'd need to change this to check if the rtINI exists.
I'll post a patch tomorrow.

Comment 1

[Marco Castelluccio [:marco]]

Attachment: Patch

There was a check for Mac using Mac functions, I've changed it to use nsIFile like in Linux and Windows.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 631633 [details] [diff] [review]
Patch

Sorry for the delay reviewing; I was having Windows build problems.

This looks correct and behaves as expected. r=myk!

https://hg.mozilla.org/integration/mozilla-inbound/rev/d7362d197229

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d7362d197229

Comment 4

[Jason Smith [:jsmith]]

Myk - Is this possible to verify from an end-user's perspective? If so, how?

Comment 5

[Marco Castelluccio [:marco]]

(In reply to Jason Smith [:jsmith] from comment #4)
> Myk - Is this possible to verify from an end-user's perspective? If so, how?

You should see the error message "This app requires that Firefox version 15 or above is installed. Firefox 15+ has not been detected." if you delete the file webapprt/webapprt.ini in the Firefox installation directory.

Comment 6

[Jason Smith [:jsmith]]

Works on Windows.

Comment 7

[Jason Smith [:jsmith]]

I'm noticing a regression on Mac when Nightly is not installed and I try to launch a web app that I no longer see the message in comment 5. Does this patch cause the bustage on Mac?

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Comment 5 is specific to Windows. Each platform stub has its own error messages. The Mac one is more confusing, you're right - let's track that in a separate bug about that specifically.

Comment 9

[Jason Smith [:jsmith]]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #8)
> Comment 5 is specific to Windows. Each platform stub has its own error
> messages. The Mac one is more confusing, you're right - let's track that in
> a separate bug about that specifically.

Gotcha. Marking as verified then. Will open a separate bug about Mac.