Wrong check in Mac and Windows webapp runtimes

VERIFIED FIXED in Firefox 16

Status

Firefox Graveyard
Webapp Runtime
P2
normal
VERIFIED FIXED
5 years ago
a year ago

People

(Reporter: marco, Unassigned)

Tracking

unspecified
Firefox 16
Bug Flags:
in-moztrap -

Details

(Whiteboard: [qa!])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
> rv = XRE_GetFileFromPath(rtIniPath, getter_AddRefs(rtINI));
> NS_ENSURE_SUCCESS(rv, false);
> 
> if (!rtINI) {

Something similar is in the Mac runtime. We'd need to change this to check if the rtINI exists.
I'll post a patch tomorrow.
Priority: -- → P2
(Reporter)

Comment 1

5 years ago
Created attachment 631633 [details] [diff] [review]
Patch

There was a check for Mac using Mac functions, I've changed it to use nsIFile like in Linux and Windows.
(Reporter)

Updated

5 years ago
Attachment #631633 - Flags: review?(myk)
Comment on attachment 631633 [details] [diff] [review]
Patch

Sorry for the delay reviewing; I was having Windows build problems.

This looks correct and behaves as expected. r=myk!

https://hg.mozilla.org/integration/mozilla-inbound/rev/d7362d197229
Attachment #631633 - Flags: review?(myk)
Attachment #631633 - Flags: review+
Attachment #631633 - Flags: checkin+

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/d7362d197229
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
Myk - Is this possible to verify from an end-user's perspective? If so, how?
Whiteboard: [qa?]
(Reporter)

Comment 5

5 years ago
(In reply to Jason Smith [:jsmith] from comment #4)
> Myk - Is this possible to verify from an end-user's perspective? If so, how?

You should see the error message "This app requires that Firefox version 15 or above is installed. Firefox 15+ has not been detected." if you delete the file webapprt/webapprt.ini in the Firefox installation directory.

Updated

5 years ago
Whiteboard: [qa?] → [qa+]

Updated

5 years ago
Flags: in-moztrap-
Works on Windows.
I'm noticing a regression on Mac when Nightly is not installed and I try to launch a web app that I no longer see the message in comment 5. Does this patch cause the bustage on Mac?

Updated

5 years ago
Whiteboard: [qa+] → [qa?]
Comment 5 is specific to Windows. Each platform stub has its own error messages. The Mac one is more confusing, you're right - let's track that in a separate bug about that specifically.
(In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment #8)
> Comment 5 is specific to Windows. Each platform stub has its own error
> messages. The Mac one is more confusing, you're right - let's track that in
> a separate bug about that specifically.

Gotcha. Marking as verified then. Will open a separate bug about Mac.
Status: RESOLVED → VERIFIED

Updated

5 years ago
Whiteboard: [qa?] → [qa!]

Updated

5 years ago
QA Contact: jsmith
(Assignee)

Updated

a year ago
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.