The default bug view has changed. See this FAQ.

de-ns-ify nsHTMLSelectAccessible

RESOLVED FIXED in mozilla16

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: surkov, Assigned: capella)

Tracking

(Blocks: 1 bug)

unspecified
mozilla16
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

5 years ago
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
(Assignee)

Comment 1

5 years ago
Created attachment 630197 [details] [diff] [review]
Patch (v1)
Attachment #630197 - Flags: review?(surkov.alexander)
(Reporter)

Comment 2

5 years ago
Comment on attachment 630197 [details] [diff] [review]
Patch (v1)

Review of attachment 630197 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/generic/DocAccessible.cpp
@@ +15,5 @@
>  #include "Role.h"
>  #include "RootAccessible.h"
>  #include "States.h"
>  
> +#include "HTMLSelectAccessible.h"

is it needed?

::: accessible/src/generic/RootAccessible.cpp
@@ +20,5 @@
>  #include "States.h"
>  
>  #include "mozilla/dom/Element.h"
> +
> +#include "HTMLSelectAccessible.h"

not needed?

::: accessible/src/html/nsHTMLSelectAccessible.cpp
@@ +312,5 @@
>    else
>      HyperTextAccessibleWrap::GetBoundsRect(aTotalBounds, aBoundingFrame);
>  }
>  
>  /** select us! close combo box if necessary*/

pls remove the comment while you are here

@@ +647,1 @@
>                                 DocAccessible* aDoc) :

wrong indentation
Attachment #630197 - Flags: review?(surkov.alexander) → review+
(Assignee)

Updated

5 years ago
Depends on: 759309
(Assignee)

Comment 3

5 years ago
Push to TRY:
https://tbpl.mozilla.org/?tree=Try&rev=72c0bc34ea7f
(Assignee)

Comment 4

5 years ago
Push to Inbound:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=2bcb94039789
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/6eb0a03905fa
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.