Closed Bug 760757 Opened 8 years ago Closed 8 years ago

de-ns-ify nsHTMLSelectAccessible

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: surkov, Assigned: capella)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
Attached patch Patch (v1)Splinter Review
Attachment #630197 - Flags: review?(surkov.alexander)
Comment on attachment 630197 [details] [diff] [review]
Patch (v1)

Review of attachment 630197 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/generic/DocAccessible.cpp
@@ +15,5 @@
>  #include "Role.h"
>  #include "RootAccessible.h"
>  #include "States.h"
>  
> +#include "HTMLSelectAccessible.h"

is it needed?

::: accessible/src/generic/RootAccessible.cpp
@@ +20,5 @@
>  #include "States.h"
>  
>  #include "mozilla/dom/Element.h"
> +
> +#include "HTMLSelectAccessible.h"

not needed?

::: accessible/src/html/nsHTMLSelectAccessible.cpp
@@ +312,5 @@
>    else
>      HyperTextAccessibleWrap::GetBoundsRect(aTotalBounds, aBoundingFrame);
>  }
>  
>  /** select us! close combo box if necessary*/

pls remove the comment while you are here

@@ +647,1 @@
>                                 DocAccessible* aDoc) :

wrong indentation
Attachment #630197 - Flags: review?(surkov.alexander) → review+
Depends on: 759309
Push to Inbound:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=2bcb94039789
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/6eb0a03905fa
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.