Last Comment Bug 760757 - de-ns-ify nsHTMLSelectAccessible
: de-ns-ify nsHTMLSelectAccessible
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla16
Assigned To: Mark Capella [:capella]
:
Mentors:
Depends on: 759309
Blocks: densifya11y
  Show dependency treegraph
 
Reported: 2012-06-01 19:35 PDT by alexander :surkov
Modified: 2012-06-07 05:51 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (v1) (35.96 KB, patch)
2012-06-05 09:48 PDT, Mark Capella [:capella]
surkov.alexander: review+
Details | Diff | Splinter Review

Description alexander :surkov 2012-06-01 19:35:23 PDT

    
Comment 1 Mark Capella [:capella] 2012-06-05 09:48:08 PDT
Created attachment 630197 [details] [diff] [review]
Patch (v1)
Comment 2 alexander :surkov 2012-06-05 09:56:03 PDT
Comment on attachment 630197 [details] [diff] [review]
Patch (v1)

Review of attachment 630197 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/generic/DocAccessible.cpp
@@ +15,5 @@
>  #include "Role.h"
>  #include "RootAccessible.h"
>  #include "States.h"
>  
> +#include "HTMLSelectAccessible.h"

is it needed?

::: accessible/src/generic/RootAccessible.cpp
@@ +20,5 @@
>  #include "States.h"
>  
>  #include "mozilla/dom/Element.h"
> +
> +#include "HTMLSelectAccessible.h"

not needed?

::: accessible/src/html/nsHTMLSelectAccessible.cpp
@@ +312,5 @@
>    else
>      HyperTextAccessibleWrap::GetBoundsRect(aTotalBounds, aBoundingFrame);
>  }
>  
>  /** select us! close combo box if necessary*/

pls remove the comment while you are here

@@ +647,1 @@
>                                 DocAccessible* aDoc) :

wrong indentation
Comment 3 Mark Capella [:capella] 2012-06-06 00:13:06 PDT
Push to TRY:
https://tbpl.mozilla.org/?tree=Try&rev=72c0bc34ea7f
Comment 4 Mark Capella [:capella] 2012-06-06 04:03:06 PDT
Push to Inbound:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=2bcb94039789

Note You need to log in before you can comment on or make changes to this bug.