760757 - de-ns-ify nsHTMLSelectAccessible

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[Mark Capella [:capella]]

Attachment: Patch (v1)

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 630197 [details] [diff] [review]
Patch (v1)

Review of attachment 630197 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/generic/DocAccessible.cpp
@@ +15,5 @@
>  #include "Role.h"
>  #include "RootAccessible.h"
>  #include "States.h"
>  
> +#include "HTMLSelectAccessible.h"

is it needed?

::: accessible/src/generic/RootAccessible.cpp
@@ +20,5 @@
>  #include "States.h"
>  
>  #include "mozilla/dom/Element.h"
> +
> +#include "HTMLSelectAccessible.h"

not needed?

::: accessible/src/html/nsHTMLSelectAccessible.cpp
@@ +312,5 @@
>    else
>      HyperTextAccessibleWrap::GetBoundsRect(aTotalBounds, aBoundingFrame);
>  }
>  
>  /** select us! close combo box if necessary*/

pls remove the comment while you are here

@@ +647,1 @@
>                                 DocAccessible* aDoc) :

wrong indentation

Comment 3

[Mark Capella [:capella]]

Push to TRY:
https://tbpl.mozilla.org/?tree=Try&rev=72c0bc34ea7f

Comment 4

[Mark Capella [:capella]]

Push to Inbound:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=2bcb94039789

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/6eb0a03905fa