de-ns-ify nsHTMLTableAccessible

RESOLVED FIXED in mozilla16

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: surkov, Assigned: capella)

Tracking

(Blocks: 1 bug)

unspecified
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

5 years ago
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
(Assignee)

Comment 1

5 years ago
Are we moving this one from /html to /generic? Not sure of the thought here, some we've moved, some stayed in the /html folder ... this one has wrap files ...
(Reporter)

Comment 2

5 years ago
(In reply to Mark Capella [:capella] from comment #1)
> Are we moving this one from /html to /generic?

no

> Not sure of the thought here,
> some we've moved, some stayed in the /html folder

we move those classes to generic folder what are shared between different markup languages. nsHTMLTableAccessible is used for HTML table element only.
(Assignee)

Comment 3

5 years ago
Created attachment 630692 [details] [diff] [review]
Patch (v1)

Interesting patch .... unused class declaration in nsaccutils interfered with namespace effort ...
Attachment #630692 - Flags: review?(surkov.alexander)
(Reporter)

Comment 4

5 years ago
Comment on attachment 630692 [details] [diff] [review]
Patch (v1)

Review of attachment 630692 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, thank you

::: accessible/src/base/nsAccUtils.h
@@ +34,2 @@
>  {
>  public:

empty lines between
class nsAccUtils
and
{
public:
?

::: accessible/src/base/nsAccessibilityService.cpp
@@ +1660,5 @@
>    }
>  
>    if (nsCoreUtils::IsHTMLTableHeader(aContent)) {
> +    Accessible* accessible = new HTMLTableHeaderCellAccessibleWrap(aContent,
> +                                                                   aDoc);

keep on the same line?

::: accessible/src/html/nsHTMLTableAccessible.cpp
@@ +290,5 @@
>  }
>  
>  nsresult
> +HTMLTableCellAccessible::GetCellIndexes(PRInt32& aRowIndex,
> +                                        PRInt32& aColIndex)

on the same line pls

@@ +1118,5 @@
>  }
>  
>  nsresult
> +HTMLTableAccessible::AddRowOrColumnToSelection(PRInt32 aIndex,
> +                                               PRUint32 aTarget)

on same line pls

@@ +1208,5 @@
>  }
>  
>  nsresult
> +HTMLTableAccessible::GetCellAt(PRInt32 aRowIndex, PRInt32 aColIndex,
> +                               nsIDOMElement* &aCell)

*& aCell

@@ +1263,5 @@
>  }
>  
>  bool
> +HTMLTableAccessible::HasDescendant(const nsAString& aTagName,
> +                                   bool aAllowEmpty)

on same line

::: accessible/src/html/nsHTMLTableAccessible.h
@@ +86,5 @@
>  
> +class HTMLTableAccessible : public AccessibleWrap,
> +                            public xpcAccessibleTable,
> +                            public nsIAccessibleTable,
> +                            public mozilla::a11y::TableAccessible

no mozilla::a11y
Attachment #630692 - Flags: review?(surkov.alexander) → review+
(Assignee)

Comment 5

5 years ago
FYI, TRY build failing on mac platform
https://tbpl.mozilla.org/php/getParsedLog.php?id=12445199&tree=Try
pointing to two moz specific type defs
mac/AccessibleWrap.h:113

not sure what moz is up to here ... thinking of try changing nsaccessibilityservice.cpp @ 388 / 398 to mozilla::a11y:: specific refs will work ...
(Reporter)

Comment 6

5 years ago
(In reply to Mark Capella [:capella] from comment #5)
> FYI, TRY build failing on mac platform
> https://tbpl.mozilla.org/php/getParsedLog.php?id=12445199&tree=Try
> pointing to two moz specific type defs
> mac/AccessibleWrap.h:113

remove those from AccessibleWrap.h
(Assignee)

Comment 7

5 years ago
That was the other thought ... wasn't sure if it was safe .... will go that way and let you know ...
(Assignee)

Comment 8

5 years ago
That's got it ! :)

Full TRY push
https://tbpl.mozilla.org/?tree=Try&rev=1018b9055ce6
(Assignee)

Comment 9

5 years ago
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=bef0c6b570a2
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/bef0c6b570a2

(Merged by Ed Morley)
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.