Closed Bug 760777 Opened 13 years ago Closed 12 years ago

Downloads Panel’s focus ring is too subtle

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 19

People

(Reporter: Aleksej, Assigned: mconley)

References

(Blocks 1 open bug)

Details

(Keywords: access, Whiteboard: [testday-20120601])

Attachments

(10 files, 8 obsolete files)

Screenshot (the GTK theme is Shiki-Dust)
321.38 KB, image/png
Details
Focusring on OSX - Before patch
15.17 KB, image/png
Details
Focusring on Ubuntu - Before patch
20.00 KB, image/png
Details
Focusring on Windows 7 - Before patch
11.63 KB, image/png
Details
Focusring on Windows XP - Before patch
5.14 KB, image/png
Details
OSX - After patch
19.15 KB, image/png
Details
Ubuntu - After patch
16.76 KB, image/png
Details
Windows 7 - After patch
7.88 KB, image/png
Details
Windows XP - After patch
10.83 KB, image/png
Details
Patch v4
5.44 KB, patch
mak
: review+
Details | Diff | Splinter Review
2012-06-01-04-20-08-mozilla-aurora-firefox-14.0a2.en-US.linux-x86_64 The focus ring, used for keyboard interaction with the Downloads Panel items, is too subtle.
2012-06-01-03-05-20-mozilla-central-firefox-15.0a1.en-US.linux-x86_64
Assignee: nobody → mconley
Attached patch Patch 1 (obsolete) — — Splinter Review
This patch sets the focus rings from #999 to #888 on each platform. Screenshots forthcoming.
Attached image Focusring on Ubuntu - After patch (obsolete) —
Attached image Focusring on Windows 7 - After patch (obsolete) —
Attached image Focusring on Windows XP - After patch (obsolete) —
Attached image Focusring on OSX - After patch (obsolete) —
I'm still a little worried about the contrast. Cc'ing David Bolter, who apparently knows about awesome tools that'll inform me what colour the focusring should be.
According to davidb's links, for a background of #F0F0F0, a foreground of #505050 is appropriate wrt contrast. Updating patch and screenshots...
Attachment #669549 - Attachment is obsolete: true
Attachment #669553 - Attachment is obsolete: true
Attachment #669554 - Attachment is obsolete: true
Attachment #669618 - Attachment is obsolete: true
Attached patch Checkpointing patch (obsolete) — — Splinter Review
Attachment #669541 - Attachment is obsolete: true
Attached patch Patch v2 (obsolete) — — Splinter Review
Attachment #669987 - Attachment is obsolete: true
Attached image OSX - After patch —
Attachment #669991 - Attachment description: Checkpointing (Windows and Ubuntu are done) → Patch v2
Attached image Ubuntu - After patch —
Attached patch Patch v3 (obsolete) — — Splinter Review
Whoops - got a rule mixed up in patch v2 that caused a pair of focusrings on download buttons. Fixed now.
Attachment #669991 - Attachment is obsolete: true
David: After a change like this, do I need someone from a11y to review it? -Mike
Flags: needinfo?(dbolter)
Yeah it is a good idea and we're happy to help. This is an improvement so thanks!
Flags: needinfo?(dbolter)
Comment on attachment 670010 [details] [diff] [review] Patch v3 Alrighty - ui-r'ing davidb by default. Let me know if there's somebody else I should direct this to.
Attachment #670010 - Flags: ui-review?(dbolter)
Let me try something tomorrow first (on Windows).
Comment on attachment 670010 [details] [diff] [review] Patch v3 ur-r=me thanks.
Attachment #670010 - Flags: ui-review?(dbolter) → ui-review+
Attachment #670010 - Flags: review?(mak77)
Comment on attachment 670010 [details] [diff] [review] Patch v3 hardcoded-colors fail :( This doesn't work for high-contrast / dark themes on Linux and Windows. The most obvious approach would be to use -moz-dialogtext.
Attachment #670010 - Flags: review?(mak77) → review-
Component: Downloads Panel → Theme
Attached patch Patch v4 — — Splinter Review
Thanks Dao - using -moz-dialogtext now.
Attachment #670010 - Attachment is obsolete: true
Attachment #670928 - Flags: review?(mak77)
Sigh, the patch wasn't applied when I tested (Windows HCM) after all. My bad. I'm taking a mulligan on last week.
Comment on attachment 670928 [details] [diff] [review] Patch v4 Review of attachment 670928 [details] [diff] [review]: ----------------------------------------------------------------- Thanks
Attachment #670928 - Flags: review?(mak77) → review+
https://hg.mozilla.org/mozilla-central/rev/6bcd2ba50e84
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
Depends on: 803564
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: