Closed Bug 803564 Opened 8 years ago Closed 8 years ago

Double focus ring around buttons in the downloads panel

Categories

(Firefox :: Theme, defect)

All
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 19

People

(Reporter: dao, Assigned: dao)

References

Details

(Keywords: regression)

Attachments

(2 files)

Attached image screenshot
No description provided.
Yikes, sorry about that. Patch coming.
Assignee: nobody → mconley
Hm - this is harder than it originally looked.

I'm not sure where that second focus ring is coming from. At first, I thought that maybe the button-icon was somehow producing it, since forcing the button-icon focus ring to be a particular colour seemed to change the inner ring.

But if I force the the button-icon focus ring to transparent, the inner ring appears again - making me suspect that forcing the button-icon ring caused me just to cover up the inner ring.

So I'm not 100% sure where that inner ring is coming from. It doesn't seem to exist with gnomestripe or pinstripe...

Any ideas where that ring might be coming from?
Flags: needinfo?(dao)
Attached patch patchSplinter Review
The focus ring is from here:
http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/winstripe/global/button.css#49
Assignee: mconley → dao
Status: NEW → ASSIGNED
Attachment #673311 - Flags: review?(mconley)
Flags: needinfo?(dao)
Comment on attachment 673311 [details] [diff] [review]
patch

Review of attachment 673311 [details] [diff] [review]:
-----------------------------------------------------------------

This looks OK if we're happy to have the focus ring around the download item (-moz-dialogtext) a different colour than the buttons (ThreeDDarkShadow).
Attachment #673311 - Flags: review?(mconley) → review+
Although I think it's strange that the rule in my original patch didn't simply override the rule you linked to.
The rule I linked to sets a border rather than an outline.
(In reply to Dão Gottwald [:dao] from comment #6)
> The rule I linked to sets a border rather than an outline.

Oh, of course.

Then, rather than simply removing the rule, could we override the border to use -moz-dialogtext, so that we appear consistent across each element in the Downloads Panel?
I wouldn't worry about it, ThreeDDarkShadow should work fine across Windows themes.
(In reply to Dão Gottwald [:dao] from comment #8)
> I wouldn't worry about it, ThreeDDarkShadow should work fine across Windows
> themes.

In that case, my r+ stands. Thanks for your work!
https://hg.mozilla.org/mozilla-central/rev/b097b04096f7
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
You need to log in before you can comment on or make changes to this bug.