803564 - Double focus ring around buttons in the downloads panel

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Dão Gottwald [:dao]]

Attachment: screenshot

Comment 1

[Mike Conley (:mconley) (:⚙️) (PTO June 8 - 12)]

Yikes, sorry about that. Patch coming.

Comment 2

[Mike Conley (:mconley) (:⚙️) (PTO June 8 - 12)]

Hm - this is harder than it originally looked.

I'm not sure where that second focus ring is coming from. At first, I thought that maybe the button-icon was somehow producing it, since forcing the button-icon focus ring to be a particular colour seemed to change the inner ring.

But if I force the the button-icon focus ring to transparent, the inner ring appears again - making me suspect that forcing the button-icon ring caused me just to cover up the inner ring.

So I'm not 100% sure where that inner ring is coming from. It doesn't seem to exist with gnomestripe or pinstripe...

Any ideas where that ring might be coming from?

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch

The focus ring is from here:
http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/winstripe/global/button.css#49

Comment 4

[Mike Conley (:mconley) (:⚙️) (PTO June 8 - 12)]

Comment on attachment 673311 [details] [diff] [review]
patch

Review of attachment 673311 [details] [diff] [review]:
-----------------------------------------------------------------

This looks OK if we're happy to have the focus ring around the download item (-moz-dialogtext) a different colour than the buttons (ThreeDDarkShadow).

Comment 5

[Mike Conley (:mconley) (:⚙️) (PTO June 8 - 12)]

Although I think it's strange that the rule in my original patch didn't simply override the rule you linked to.

Comment 6

[Dão Gottwald [:dao]]

The rule I linked to sets a border rather than an outline.

Comment 7

[Mike Conley (:mconley) (:⚙️) (PTO June 8 - 12)]

(In reply to Dão Gottwald [:dao] from comment #6)
> The rule I linked to sets a border rather than an outline.

Oh, of course.

Then, rather than simply removing the rule, could we override the border to use -moz-dialogtext, so that we appear consistent across each element in the Downloads Panel?

Comment 8

[Dão Gottwald [:dao]]

I wouldn't worry about it, ThreeDDarkShadow should work fine across Windows themes.

Comment 9

[Mike Conley (:mconley) (:⚙️) (PTO June 8 - 12)]

(In reply to Dão Gottwald [:dao] from comment #8)
> I wouldn't worry about it, ThreeDDarkShadow should work fine across Windows
> themes.

In that case, my r+ stands. Thanks for your work!

Comment 10

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b097b04096f7

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b097b04096f7