Closed
Bug 760817
Opened 12 years ago
Closed 12 years ago
The add-ons validator does not accept the new dictionary add-ons introduced in Firefox 10
Categories
(addons.mozilla.org Graveyard :: Add-on Validation, defect)
addons.mozilla.org Graveyard
Add-on Validation
Tracking
(Not tracked)
RESOLVED
FIXED
BW-2.1
People
(Reporter: bugzilla, Assigned: kmag)
References
Details
Attachments
(1 file)
620.51 KB,
application/x-xpinstall
|
Details |
I have updated my dictionary add-on to not require a restart when installing. But addons.mozilla.org does not allow me to upload this new version. STR: Try to upload the attached add-on Actual results: Upload fails with the following errors: https://addons.mozilla.org/en-US/developers/upload/ca6eb55cde2e40d782c054e64286cbef General Tests 2 errors, 0 warnings Invalid <em:type> value. Error: The only valid values for <em:type> are 2, 4, 8, and 32. Any other values are either invalid or deprecated. install.rdf Unable to determine add-on type Error: The type detection algorithm could not determine the type of the add-on. Expected results: The add-on is uploaded. Here are some potential validation requirements for the new add-on type: * em:type must be 64 * em:unpack must be true (Bug 660717) * minVersion must correspond to at least Gecko 10.0a1 * the addon should have a "dictionaries" subdirectory with at least one pair of .dic and .aff files
Assignee | ||
Comment 1•12 years ago
|
||
https://github.com/mozilla/amo-validator/pull/157
Assignee: nobody → kmaglione+bmo
Assignee | ||
Comment 2•12 years ago
|
||
We already have tests for em:unpack in dictionary add-ons, and I don't think we need the minVersion checks (I think these are compatible with traditional dictionary add-ons). That pull makes it possible to upload them. It would be nice to add verifications that they actually contain dictionary files.
Reporter | ||
Comment 3•12 years ago
|
||
Thank you very much! You are right that minVersion check is not required. Installation of the add-on will simply fail in a lower version of Firefox, so users cannot risk ending up with a broken Firefox or anything else serious.
Reporter | ||
Comment 4•12 years ago
|
||
The status of this bug is still "New" but I tried again a few days ago, and it worked now, so it seems fixed to me.
Target Milestone: --- → BW-2.1
Reporter | ||
Comment 5•12 years ago
|
||
(I have no idea why Bugzilla changed Target Milestone with that comment)
Comment 6•12 years ago
|
||
This was merged a while ago. Fixed. https://github.com/mozilla/amo-validator/commit/3862022cdbf7c93ca78ac69013c53688a58f66a5
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•