Need to reload editor page after installing Add-on Builder Helper, else Test button complains about ABH not being installed

RESOLVED FIXED

Status

addons.mozilla.org Graveyard
Add-on Builder
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: aryx, Assigned: ochameau)

Tracking

Details

Attachments

(1 attachment)

Firefox 12.0, Windows XP SP 3 32 bit, tested on https://builder.addons.mozilla.org

If someone wants to test a SDK-based add-on, let's say https://builder.addons.mozilla.org/addon/1055014/latest/ and hasn't yet the Add-on Builder Helper add-on (ABH) installed, a notification/popup tells the user to install it. But after installing, clicking the Test button still yields complains about ABH not being installed. A reload of the page fixes this.

Updated

5 years ago
Duplicate of this bug: 783769
I believe best would be if ABH would try to reload the page after being installed.
If some changes were added and unsaved - onbeforeunload should pop up.
If that is the case, it would help to cc Alex on this bug as he is maintaining ABH.
(Assignee)

Updated

5 years ago
Depends on: 708190
(Assignee)

Comment 4

5 years ago
Created attachment 656432 [details]
Pull request 5

That should be it. Just use brand new "existing" PageMod flag in order to get mozFlighdeck object injected in already opened tabs.
Assignee: nobody → poirot.alex
(Assignee)

Updated

5 years ago
Depends on: 733582
(Assignee)

Comment 5

5 years ago
Comment on attachment 656432 [details]
Pull request 5

We need patch from bug 733582 in order to refactor addon builder helper to work with current SDK master.
Then we are able to use new PageMod flags introduced in this patch and fix this bug.
So please review bug 733582's patch first.
Attachment #656432 - Flags: review?(rFobic)
Attachment #656432 - Flags: review?(rFobic) → review+
(Assignee)

Comment 6

5 years ago
Landed:
https://github.com/mozilla/addon-builder-helper/commit/2b7b5044d510a4a85ba900d9893e453b2cc508dc

We will have to wait for first 1.11 SDK beta to build ABH as we rely on new page-mod attribute to be due in this release.
Is this done then? We're on SDK 1.12
(Assignee)

Comment 8

5 years ago
We talked multiples times about spinning an updated version of ABH. But given the version currently available on AMO, It doesn't seems to have been done!

Jeff, Can you do that ?

Piotr, it may help, if you have AMO credentials for this addon, to register me or Jeff as developer. So that we can update it without having to bug Daniel.
Adding Erik to the cc - I believe he has the AMO juice to update the add-on.
(Assignee)

Updated

5 years ago
Depends on: 834924
(Assignee)

Comment 10

5 years ago
1.5 version has been released and fixed that issue.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.