760853 - Need to reload editor page after installing Add-on Builder Helper, else Test button complains about ABH not being installed

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Add-on Builder, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox 12.0, Windows XP SP 3 32 bit, tested on https://builder.addons.mozilla.org

If someone wants to test a SDK-based add-on, let's say https://builder.addons.mozilla.org/addon/1055014/latest/ and hasn't yet the Add-on Builder Helper add-on (ABH) installed, a notification/popup tells the user to install it. But after installing, clicking the Test button still yields complains about ABH not being installed. A reload of the page fixes this.

Comment 2

[Piotr Zalewa [:zalun]]

I believe best would be if ABH would try to reload the page after being installed.
If some changes were added and unsaved - onbeforeunload should pop up.

Comment 3

[Jeff Griffiths (:canuckistani) (:⚡︎)]

If that is the case, it would help to cc Alex on this bug as he is maintaining ABH.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Pull request 5

That should be it. Just use brand new "existing" PageMod flag in order to get mozFlighdeck object injected in already opened tabs.

Comment 5

[Alexandre Poirot [:ochameau]]

Comment on attachment 656432 [details]
Pull request 5

We need patch from bug 733582 in order to refactor addon builder helper to work with current SDK master.
Then we are able to use new PageMod flags introduced in this patch and fix this bug.
So please review bug 733582's patch first.

Comment 6

[Alexandre Poirot [:ochameau]]

Landed:
https://github.com/mozilla/addon-builder-helper/commit/2b7b5044d510a4a85ba900d9893e453b2cc508dc

We will have to wait for first 1.11 SDK beta to build ABH as we rely on new page-mod attribute to be due in this release.

Comment 7

[Piotr Zalewa [:zalun]]

Is this done then? We're on SDK 1.12

Comment 8

[Alexandre Poirot [:ochameau]]

We talked multiples times about spinning an updated version of ABH. But given the version currently available on AMO, It doesn't seems to have been done!

Jeff, Can you do that ?

Piotr, it may help, if you have AMO credentials for this addon, to register me or Jeff as developer. So that we can update it without having to bug Daniel.

Comment 9

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Adding Erik to the cc - I believe he has the AMO juice to update the add-on.

Comment 10

[Alexandre Poirot [:ochameau]]

1.5 version has been released and fixed that issue.