76091 - leak increase from one line XBL change

Status: VERIFIED FIXED

(Core :: Security: CAPS, defect, P1)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

DESCRIPTION:  blake's one line change to
themes/classic/global/win/classicBindings.xml revision 1.25 caused a leak
increase around 2K on tinderbox.  Since tinderbox leaks are going up and down
so much, here are the differences in leaks from just starting mozilla and
exiting in my own build:

--NEW-LEAKS-----------------------------------leaks------leaks%-----------------------
nsStdURL                                          4          -
nsXULElement                                     80          -
nsGenericFactory                                 20          -
RDFServiceImpl                                   60          -
nsDOMWindowList                                  24          -
nsAuthURLParser                                  12          -
LocationImpl                                     28          -
AtomImpl                                        880     189.47%
nsCodebasePrincipal                             120     100.00%
NameSpaceManagerImpl                             24     100.00%
nsAggregatePrincipal                            144     100.00%
GlobalWindowImpl                                732      50.00%
nsVoidArray                                     120      25.00%
nsStr                                           500      13.64%

The change (which was for bug 27289) is:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/themes/classic/global/win&command=DIFF_FRAMESET&file=classicBindings.xml&rev1=1.24&rev2=1.25&root=/cvsroot

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This turns out to be a one-liner in a checkin by mstoltz from a few weeks ago.
It may even be what's causing the leaks to oscillate.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: fix for leak

Comment 3

[Blake Ross]

r=blake

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

There are two more in the same file.  One of the other two was also probably
causing a leak on tinderbox.  Revised patch coming.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: fix for 3 leaks

Comment 6

[David Hyatt]

sr=hyatt

Comment 7

[Mitchell Stoltz (not reading bugmail)]

Looks fine to me. r-mstoltz, go ahead and check in.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in 2001-04-16 17:12 PDT.

Comment 9

[ckritzer (gone)]

This looks to me like something not easily 'testable'.

So.


Based on comments by blake, dbaron, mstoltz:

Marking VERIFIED FIXED on:
-MacOS91 2001-05-23-08-trunk
-Win98SE 2001-05-23-09-trunk
-LinRH62 2001-05-23-08-trunk

Comment 10

[ckritzer (gone)]

No, really...