[compare-locale] Error on crashreporter.ini with MPL2 boilerplate followed by empty line

RESOLVED FIXED

Status

Mozilla Localizations
Infrastructure
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: flod, Assigned: Pike)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
Italian file
http://hg.mozilla.org/l10n-central/it/file/c7bee6ec8ca3/toolkit/crashreporter/crashreporter.ini

compare-locales generates this error

Unparsed content "; This Source Code Form is subject to the terms of the Mozilla Public ; License, v. 2.0. If a copy of the MPL was not distributed with this ; file, You can obtain one at http://mozilla.org/MPL/2.0/. [Strings]" at 0-209

Adding this comment makes the error disappears
# This file is in the UTF-8 encoding
(Assignee)

Comment 1

5 years ago
My suspicion is that http://hg.mozilla.org/l10n/compare-locales/file/f4effbecaaec/lib/Mozilla/Parser.py#l355 doesn't allow the empty line in that constellation.

Path to fix would be to mimic the tests in http://hg.mozilla.org/l10n/compare-locales/file/f4effbecaaec/lib/Mozilla/tests/unitProperties.py, verify that it breaks, and then patch.

In other words, this is a nice patch for someone to start hacking on compare-locales.

Comment 2

5 years ago
Seeing that on https://l10n.mozilla.org/dashboard/compare?run=224504 as well, and there the empty lines come from the originals, see http://hg.mozilla.org/comm-central/file/4efc4d422213/suite/locales/en-US/crashreporter/crashreporter-override.ini and http://hg.mozilla.org/comm-central/file/4efc4d422213/suite/locales/en-US/updater/updater.ini
Summary: [compare-locale] Error on crashreporter.ini when UTF8 comment is missing → [compare-locale] Error on crashreporter.ini with MPL2 boilerplate followed by empty line
(Assignee)

Comment 3

5 years ago
http://hg.mozilla.org/l10n/compare-locales/rev/98efaa127844, FIXED.

I also updated the seamonkey runs for central and aurora.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Blocks: 865001
You need to log in before you can comment on or make changes to this bug.