761000 - Consolidate cmd_quit/key_quit into utilityOverlay

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Ian Neal]

At the moment there are various cmd_quit and key_quit scattered across the code. These could be consolidated and simplified by adding cmd_quit to the tasksCommands commandset and key_quit to a tasksKeys keyset in utilityOverlay.xul.

Comment 1

[Ian Neal]

Attachment: Do the consolidation [Checked in: Comment 6]

Comment 2

[Philip Chee]

> -    // In editor.js
> -    FinishHTMLSource();
> -    goQuitApplication();
Don't you still need |SetEditMode(gPreviousNonSourceDisplayMode)| before |goQuitApplication()|?

Comment 3

[Ian Neal]

(In reply to Philip Chee from comment #2)
> > -    // In editor.js
> > -    FinishHTMLSource();
> > -    goQuitApplication();
> Don't you still need |SetEditMode(gPreviousNonSourceDisplayMode)| before
> |goQuitApplication()|?

Prior to this patch the existing cmd_quit already gets overlayed from utilityOverlay.xul so never calls this function.

Comment 4

[[e-mail]]

(In reply to Ian Neal from comment #3)
> (In reply to Philip Chee from comment #2)
> > > -    // In editor.js
> > > -    FinishHTMLSource();
> > > -    goQuitApplication();
> > Don't you still need |SetEditMode(gPreviousNonSourceDisplayMode)| before
> > |goQuitApplication()|?
> Prior to this patch the existing cmd_quit already gets overlayed from
> utilityOverlay.xul so never calls this function.
ITYM platformCommunicatorOverlay.xul

Presumably a similar argument applies to MsgComposeCommands.js which explains why this change won't break Thunderbird?

Comment 5

[Ian Neal]

(In reply to [e-mail] from comment #4)
> (In reply to Ian Neal from comment #3)
> > (In reply to Philip Chee from comment #2)
> > > > -    // In editor.js
> > > > -    FinishHTMLSource();
> > > > -    goQuitApplication();
> > > Don't you still need |SetEditMode(gPreviousNonSourceDisplayMode)| before
> > > |goQuitApplication()|?
> > Prior to this patch the existing cmd_quit already gets overlayed from
> > utilityOverlay.xul so never calls this function.
> ITYM platformCommunicatorOverlay.xul
Well utilityOverlay pulls in the relevant platformCommunicatorOverlay.xul file, so yes.
> 
> Presumably a similar argument applies to MsgComposeCommands.js which
> explains why this change won't break Thunderbird?

Yes, as it is basically the same bit of composer code that is being overlayed.

Comment 6

[Ian Neal]

Comment on attachment 629622 [details] [diff] [review]
Do the consolidation [Checked in: Comment 6]

http://hg.mozilla.org/comm-central/rev/38f9db262c93