Consolidate cmd_quit/key_quit into utilityOverlay

RESOLVED FIXED in seamonkey2.13

Status

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

Tracking

Trunk
seamonkey2.13
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

7 years ago
At the moment there are various cmd_quit and key_quit scattered across the code. These could be consolidated and simplified by adding cmd_quit to the tasksCommands commandset and key_quit to a tasksKeys keyset in utilityOverlay.xul.
Assignee

Comment 1

7 years ago
Attachment #629622 - Flags: review?(neil)

Comment 2

7 years ago
> -    // In editor.js
> -    FinishHTMLSource();
> -    goQuitApplication();
Don't you still need |SetEditMode(gPreviousNonSourceDisplayMode)| before |goQuitApplication()|?
Assignee

Comment 3

7 years ago
(In reply to Philip Chee from comment #2)
> > -    // In editor.js
> > -    FinishHTMLSource();
> > -    goQuitApplication();
> Don't you still need |SetEditMode(gPreviousNonSourceDisplayMode)| before
> |goQuitApplication()|?

Prior to this patch the existing cmd_quit already gets overlayed from utilityOverlay.xul so never calls this function.
(In reply to Ian Neal from comment #3)
> (In reply to Philip Chee from comment #2)
> > > -    // In editor.js
> > > -    FinishHTMLSource();
> > > -    goQuitApplication();
> > Don't you still need |SetEditMode(gPreviousNonSourceDisplayMode)| before
> > |goQuitApplication()|?
> Prior to this patch the existing cmd_quit already gets overlayed from
> utilityOverlay.xul so never calls this function.
ITYM platformCommunicatorOverlay.xul

Presumably a similar argument applies to MsgComposeCommands.js which explains why this change won't break Thunderbird?
Assignee

Comment 5

7 years ago
(In reply to neil@parkwaycc.co.uk from comment #4)
> (In reply to Ian Neal from comment #3)
> > (In reply to Philip Chee from comment #2)
> > > > -    // In editor.js
> > > > -    FinishHTMLSource();
> > > > -    goQuitApplication();
> > > Don't you still need |SetEditMode(gPreviousNonSourceDisplayMode)| before
> > > |goQuitApplication()|?
> > Prior to this patch the existing cmd_quit already gets overlayed from
> > utilityOverlay.xul so never calls this function.
> ITYM platformCommunicatorOverlay.xul
Well utilityOverlay pulls in the relevant platformCommunicatorOverlay.xul file, so yes.
> 
> Presumably a similar argument applies to MsgComposeCommands.js which
> explains why this change won't break Thunderbird?

Yes, as it is basically the same bit of composer code that is being overlayed.
Attachment #629622 - Flags: review?(neil) → review+
Assignee

Comment 6

7 years ago
Comment on attachment 629622 [details] [diff] [review]
Do the consolidation [Checked in: Comment 6]

http://hg.mozilla.org/comm-central/rev/38f9db262c93
Attachment #629622 - Attachment description: Do the consolidation → Do the consolidation [Checked in: Comment 6]
Assignee

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.13
You need to log in before you can comment on or make changes to this bug.