761069 - B2G MMS: support email addressing model

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Vicamo Yang [:vicamo][:vyang]]

The MMS Addressing Model[1] lists four possible categories: email, device-address, alphanum-shortcode, and num-shortcode. Current implementation in bug 749856 uses "unknown" for email addresses.

Comment 1

[JP Rosevear [:jpr]]

MMS is desired to be ready for basecamp, but does not actually block.

Comment 2

[Michael:mtreese]

MMS is requred for v1, but not for Brazil

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Attachment: v0

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

Attachment: v1

break the long long regex down.

Comment 5

[Philipp von Weitershausen [:philikon]]

Comment on attachment 645220 [details] [diff] [review]
v1

Review of attachment 645220 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/mms/src/ril/MmsPduHelper.jsm
@@ +97,5 @@
> +      // 3.4 of RFC2822, but excluding the obsolete definitions as indicated by
> +      // the "obs-" prefix. Here we match only `addr-spec`.
> +      let dotatom = "[a-zA-Z\d!#$%&'*+\-/=?^_`{|}~]+";
> +      let addrspec = new RegExp(dotatom + "(?:" + dotatom + ")*@" +
> +                                dotatom + "(?:" + dotatom + ")*");

I'm not sure I'm comfortable with validating the email address with such a specific RegExp. I can think of several invalid email addresses that would pass this test. Conversely I bet there are valid addresses that wouldn't. Maybe we can just check for one and only one "@" character in the string, and leave the validation up to the email protocol layer?

(Also, it's unnecessary to compile the RegExp every time we pass through this code. I would suggest a lazy global, if we were to keep it.)

Comment 6

[Vicamo Yang [:vicamo][:vyang]]

Attachment: v2

Match a '@' char instead and maybe come back for more strict/completed checks if necessary. Thanks Philipp.

Comment 7

[Vicamo Yang [:vicamo][:vyang]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/fec33ba83a18

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/fec33ba83a18