Closed Bug 761419 Opened 9 years ago Closed 9 years ago

Build failure in content/media/gstreamer/nsGStreamerReader.cpp when using clang

Categories

(Core :: Audio/Video, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: padenot, Assigned: padenot)

Details

Attachments

(1 file, 1 obsolete file)

Compilation fails when enabling gstreamer and using clang (version 3.0-6ubuntu3), with the following error :

http://pastebin.mozilla.org/1655529
Attached patch Possible patch. (obsolete) — Splinter Review
Possible patch. Untested because of bug 761409.
Comment on attachment 629982 [details] [diff] [review]
Possible patch.

I could test that applying the patch from bug 761030, seems to do fine.
Attachment #629982 - Flags: review?(kinetik)
Comment on attachment 629982 [details] [diff] [review]
Possible patch.

Thanks!
Attachment #629982 - Flags: review?(kinetik) → review+
Pasting the error here for anyone searching for this problem:

content/media/gstreamer/nsGStreamerReader.cpp:194:5: error: constant expression evaluates to -3 which cannot be narrowed to type 'guint' (aka 'unsigned int')
    ~GST_PLAY_FLAG_AUDIO, ~GST_PLAY_FLAG_VIDEO};
Assignee: nobody → paul
Attachment #629982 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/0da00a304a4a
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/0da00a304a4a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.