761419 - Build failure in content/media/gstreamer/nsGStreamerReader.cpp when using clang

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Paul Adenot (:padenot)]

Compilation fails when enabling gstreamer and using clang (version 3.0-6ubuntu3), with the following error :

http://pastebin.mozilla.org/1655529

Comment 1

[Paul Adenot (:padenot)]

Attachment: Possible patch.

Possible patch. Untested because of bug 761409.

Comment 2

[Paul Adenot (:padenot)]

Comment on attachment 629982 [details] [diff] [review]
Possible patch.

I could test that applying the patch from bug 761030, seems to do fine.

Comment 3

[Matthew Gregan [:kinetik]]

Comment on attachment 629982 [details] [diff] [review]
Possible patch.

Thanks!

Comment 4

[Matthew Gregan [:kinetik]]

Pasting the error here for anyone searching for this problem:

content/media/gstreamer/nsGStreamerReader.cpp:194:5: error: constant expression evaluates to -3 which cannot be narrowed to type 'guint' (aka 'unsigned int')
    ~GST_PLAY_FLAG_AUDIO, ~GST_PLAY_FLAG_VIDEO};

Comment 5

[Paul Adenot (:padenot)]

Attachment: (Added r=kinetik)

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0da00a304a4a

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0da00a304a4a