Closed Bug 76144 Opened 23 years ago Closed 23 years ago

leaks in lcglue.cpp and nsCSecurityContext.cpp

Categories

(Core Graveyard :: Java: OJI, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: dbaron, Assigned: edburns)

Details

(Keywords: memory-leak, Whiteboard: [oji_working])

Attachments

(1 file)

In modules/oji/src/lcglue.cpp and nsCSecurityContext.cpp, there are lines of the
form:

nsCOMPtr<nsIScriptGlobalObject> global = scriptContext->GetGlobalObject();

This is an automatic leak.  It should be replaced with

nsCOMPtr<nsIScriptGlobalObject>
global(dont_AddRef(scriptContext->GetGlobalObject()));

See bug 76114 and bug 76091 for similar problems.
This builds ok on Win32 and linux with today's trunk.  When the build 
completes, I'll test.
Status: NEW → ASSIGNED
Whiteboard: [oji_working]
r=dbaron, assuming you'll test it appropriately.
I've tested this on win32 and Linux.  It works.
ra=edburns for OJI module.
sr=waterson
Builds on win32, Solaris, and Linux.
Fix checked in.
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
qa->pmac
QA Contact: shrir → pmac
Verified the patches.
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: