Closed
Bug 761481
Opened 13 years ago
Closed 13 years ago
GCLI help output does not display the first time
Categories
(DevTools :: General, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 16
People
(Reporter: dangoor, Assigned: jwalker)
References
Details
Attachments
(1 file, 1 obsolete file)
2.65 KB,
patch
|
dcamp
:
review+
|
Details | Diff | Splinter Review |
STR:
1. With Developer Toolbar closed, press the keyboard shortcut to open the toolbar
2. type "help" and hit enter
3. note the lack of output
4. type "help" and hit enter again
5. ahh, there it is!
expected:
output at step 3
This is in the 2012-06-04 Nightly on Mac.
Reporter | ||
Updated•13 years ago
|
Assignee: jwalker → nobody
Comment 1•13 years ago
|
||
Thank you, I meant to file this last weekend but it slipped my mind.
Assignee | ||
Updated•13 years ago
|
Priority: -- → P1
Summary: [gcli] help output does not display the first time → GCLI help output does not display the first time
Target Milestone: --- → Firefox 16
Assignee | ||
Comment 2•13 years ago
|
||
Hey Neil - I wonder if you could help with a panel problem.
2 things to add to Kevin's STR:
- the pref to enable the toolbar is: devtools.toolbar.enabled=true
- this happens on Mac/Linux but not Windows
If you open browser/devtools/shared/DeveloperToolbar.jsm, line 354, you can see the call to openPopup, it is called at the right time on all OSes.
Relevant to the discussion is the _resize() function just below show(), although from adding debug to that function, it looks like sane values are being used for the height/width (i.e. 265x275) and those numbers are the same whether the output is displayed or not.
Thanks.
Comment 3•13 years ago
|
||
The panel is first resized to one size, then some left margin is being added to it, then the panel is resized to accomodate this margin.
<panel xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" id="gcli-tooltip" class="gcli-panel" noautofocus="true" noautohide="true"><iframe xmlns="http://www.w3.org/1999/xhtml" height="0" id="gcli-tooltip-frame" src="chrome://browser/content/devtools/gclitooltip.xhtml" flex="1" style="margin-left: 10px;"></iframe></panel>
Maybe you mean to add the margin on the panel itself, or in the iframe's content?
Is the margin or its size dependent on the size of the panel? If not, it should be applied before opening the panel.
Comment 4•13 years ago
|
||
Er, that comment was meant for bug 760450
Comment 5•13 years ago
|
||
Why is the panel being resized three times when being opened?
Assignee | ||
Comment 6•13 years ago
|
||
(In reply to Neil Deakin from comment #5)
> Why is the panel being resized three times when being opened?
Twice?
this._panel.ownerDocument.defaultView.setTimeout(function() {
this._resize();
}.bind(this), 0);
this._panel.openPopup(this._input, "before_start", 0, 0, false, false, null);
this._resize();
this._input.focus();
Displaying the panel causes it to re-flow, which can change the size it should be,
so we need to resize the iframe after the panel has displayed.
Comment 7•13 years ago
|
||
The panel is also being resized at:
else if (aEvent.type == "resize") {
this.outputPanel._resize();
}
Assignee | ||
Comment 8•13 years ago
|
||
(In reply to Neil Deakin from comment #7)
> The panel is also being resized at:
>
> else if (aEvent.type == "resize") {
> this.outputPanel._resize();
> }
Ah, right that's so that when the window is resized, we ensure the output panel is the same width as the input area.
Assignee | ||
Comment 9•13 years ago
|
||
Neil - I'd really like to get this fixed, can I get you any more info to help work out what's wrong?
Comment 10•13 years ago
|
||
I think I tested commenting out the resize I mentioned in comment 7 and the size worked fine. You might want to see if there's a way to skip that in this case. Possibly by seeing if the window really did change size.
Assignee | ||
Comment 11•13 years ago
|
||
Updated•13 years ago
|
Attachment #636424 -
Flags: review?(dcamp) → review+
Assignee | ||
Comment 12•13 years ago
|
||
Assignee | ||
Comment 13•13 years ago
|
||
The previous version of this patch was done in somewhat of a hurry, this is a slightly better version of the same thing.
Attachment #636424 -
Attachment is obsolete: true
Attachment #637439 -
Flags: review?(dcamp)
Updated•13 years ago
|
Attachment #637439 -
Flags: review?(dcamp) → review+
Assignee | ||
Comment 14•13 years ago
|
||
Assignee | ||
Comment 15•13 years ago
|
||
Assignee | ||
Comment 16•13 years ago
|
||
Whiteboard: [fixed-in-fx-team]
Comment 17•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Assignee | ||
Comment 18•13 years ago
|
||
This issue has returned.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 19•13 years ago
|
||
Actually it's not a problem with this bug.
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•