The developer toolbar should be preffed on by default [devtb][GCLI]

RESOLVED FIXED in Firefox 16

Status

()

Firefox
Developer Tools: Console
P1
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jwalker, Assigned: jwalker)

Tracking

unspecified
Firefox 16
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

Comment hidden (empty)
Component: Developer Tools → Developer Tools: Console
QA Contact: developer.tools → developer.tools.console
Created attachment 636423 [details] [diff] [review]
Upload 1
Assignee: nobody → jwalker
Status: NEW → ASSIGNED
Attachment #636423 - Flags: review?(dcamp)
https://tbpl.mozilla.org/?tree=Try&rev=986cd926eb22

Updated

5 years ago
Attachment #636423 - Flags: review?(dcamp) → review+
Blocks: 769186
Created attachment 637428 [details] [diff] [review]
Upload 2


Will need r from a browser peer.

This removes the key sequence so we can land. Bug 769186 puts it back in again, however we will need to fix the conflict with the editor before we can do that.
Attachment #636423 - Attachment is obsolete: true
Attachment #637428 - Flags: review?(dcamp)
Comment on attachment 637428 [details] [diff] [review]
Upload 2

Hey Tim - trivial patch that prefs the toolbar on by default, and removes the key sequence as a result of a conflict with the editor.
Attachment #637428 - Flags: review?(dcamp) → review?(ttaubert)
Comment on attachment 637428 [details] [diff] [review]
Upload 2

Review of attachment 637428 [details] [diff] [review]:
-----------------------------------------------------------------

Do you plan to leave the developer toolbar preffed on for Aurora as well after the migration or will this be enabled for a couple of trains for Nightly only? If it's the latter then it might make sense to move this to browser/branding/nightly/pref/firefox-branding.js so you don't have to revert it when merged to Aurora.
I think we're feeling more confident about the commands that we've got now and our progress, the intention is to pref this on, and leave it on. Clearly if things don't go according to plan, we can pref it off again.

Title updated to reflect this.
Summary: The developer toolbar should be preffed on by default for testing on nightly only [devtb][GCLI] → The developer toolbar should be preffed on by default [devtb][GCLI]
(In reply to Tim Taubert [:ttaubert] from comment #5)
> Do you plan to leave the developer toolbar preffed on for Aurora as well
> after the migration or will this be enabled for a couple of trains for
> Nightly only? If it's the latter then it might make sense to move this to
> browser/branding/nightly/pref/firefox-branding.js so you don't have to
> revert it when merged to Aurora.

Gavin had reservations about using the branding pref file for this purpose, see bug 749628 comment 39.
(In reply to Panos Astithas [:past] from comment #7)
> Gavin had reservations about using the branding pref file for this purpose,
> see bug 749628 comment 39.

Aha! Thanks for the hint.
Attachment #637428 - Flags: review?(ttaubert) → review+
Created attachment 637833 [details] [diff] [review]
Upload 3

The correct way to remove a key sequence ...
Sorry Tim!
Attachment #637428 - Attachment is obsolete: true
Attachment #637833 - Flags: review?(ttaubert)
Created attachment 637835 [details] [diff] [review]
Upload 4

Rushing.
This removes devToolbar.commandkey too.
Attachment #637833 - Attachment is obsolete: true
Attachment #637833 - Flags: review?(ttaubert)
Attachment #637835 - Flags: review?(ttaubert)
https://tbpl.mozilla.org/?tree=Try&rev=9d8184b3d582
Attachment #637835 - Flags: review?(ttaubert) → review+
https://tbpl.mozilla.org/?tree=Try&rev=59729f63ee39
https://tbpl.mozilla.org/?tree=Fx-Team&rev=124c0182df1c
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/5d6c06259bb1
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
You need to log in before you can comment on or make changes to this bug.