761489 - New addon page overflows when text wrapped

Status: VERIFIED FIXED

Description

[Geoff Lankow (:darktrojan)]

Created attachment 630043 [details]
screenshot

This is caused entirely by XUL line wrapping, bug 492645. We could either work around it or wait for that bug to get fixed.

Comment 1

[Geoff Lankow (:darktrojan)]

I can fix this by removing the overflow:hidden on #addon-container.

Comment 2

[[e-mail]]

(In reply to Geoff Lankow from comment #1)
> I can fix this by removing the overflow:hidden on #addon-container.
Without regressing bug 595656?

Comment 3

[Geoff Lankow (:darktrojan)]

I'll override it with the page's stylesheet.

Comment 4

[Geoff Lankow (:darktrojan)]

Created attachment 630421 [details] [diff] [review]
fix

Comment 5

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 630421 [details] [diff] [review]
fix

Review of attachment 630421 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/themes/gnomestripe/mozapps/extensions/newaddon.css
@@ +22,5 @@
>    -moz-box-flex: 3;
>  }
>  
>  #addon-container {
> +  overflow: visible; /* bug 761489 */

The bug number is easy enough to find in HG history - if it warrants a comment, it should be a direct description of why it's needed.

Comment 6

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4ec43f1c0d12

Comment 7

[Geoff Lankow (:darktrojan)]

Comment on attachment 630421 [details] [diff] [review]
fix

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 595656
User impact if declined: new addon page may become unusable if the buttons overflow off the bottom
Testing completed (on m-c, etc.): manually tested
Risk to taking this patch (and alternatives if risky): virtually none
String or UUID changes made by this patch: none

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/4ec43f1c0d12

Comment 9

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9291d6f5fd6e

Comment 11

[Paul Silaghi, QA [:pauly]]

Able to see the issue on Nightly 2012-06-05.
Verified fixed on FF 15b5 on Win 7, Ubuntu 12.04 and Mac OS X 10.6.