Closed
Bug 761489
Opened 12 years ago
Closed 12 years ago
New addon page overflows when text wrapped
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla16
Tracking | Status | |
---|---|---|
firefox15 | --- | verified |
People
(Reporter: darktrojan, Assigned: darktrojan)
References
Details
Attachments
(2 files)
20.06 KB,
image/png
|
Details | |
1.81 KB,
patch
|
Unfocused
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
This is caused entirely by XUL line wrapping, bug 492645. We could either work around it or wait for that bug to get fixed.
Assignee | ||
Comment 1•12 years ago
|
||
I can fix this by removing the overflow:hidden on #addon-container.
Comment 2•12 years ago
|
||
(In reply to Geoff Lankow from comment #1)
> I can fix this by removing the overflow:hidden on #addon-container.
Without regressing bug 595656?
Blocks: 595656
Assignee | ||
Comment 3•12 years ago
|
||
I'll override it with the page's stylesheet.
Assignee | ||
Comment 4•12 years ago
|
||
Comment 5•12 years ago
|
||
Comment on attachment 630421 [details] [diff] [review]
fix
Review of attachment 630421 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/themes/gnomestripe/mozapps/extensions/newaddon.css
@@ +22,5 @@
> -moz-box-flex: 3;
> }
>
> #addon-container {
> + overflow: visible; /* bug 761489 */
The bug number is easy enough to find in HG history - if it warrants a comment, it should be a direct description of why it's needed.
Attachment #630421 -
Flags: review?(bmcbride) → review+
Assignee | ||
Comment 6•12 years ago
|
||
No longer depends on: 492645
Flags: in-testsuite-
Flags: in-moztrap-
Flags: in-litmus-
Target Milestone: --- → mozilla16
Assignee | ||
Comment 7•12 years ago
|
||
Comment on attachment 630421 [details] [diff] [review]
fix
[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 595656
User impact if declined: new addon page may become unusable if the buttons overflow off the bottom
Testing completed (on m-c, etc.): manually tested
Risk to taking this patch (and alternatives if risky): virtually none
String or UUID changes made by this patch: none
Attachment #630421 -
Flags: approval-mozilla-aurora?
Comment 8•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Attachment #630421 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 9•12 years ago
|
||
status-firefox15:
--- → fixed
Comment 11•12 years ago
|
||
Able to see the issue on Nightly 2012-06-05.
Verified fixed on FF 15b5 on Win 7, Ubuntu 12.04 and Mac OS X 10.6.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•