Closed Bug 761489 Opened 10 years ago Closed 10 years ago

New addon page overflows when text wrapped

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla16
Tracking Flags:
Tracking Status
firefox15 --- verified

People

(Reporter: darktrojan, Assigned: darktrojan)

References

Details

Attachments

(2 files)

screenshot
20.06 KB, image/png
Details
fix
1.81 KB, patch
Unfocused
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Attached image screenshot — 
This is caused entirely by XUL line wrapping, bug 492645. We could either work around it or wait for that bug to get fixed.
I can fix this by removing the overflow:hidden on #addon-container.
(In reply to Geoff Lankow from comment #1)
> I can fix this by removing the overflow:hidden on #addon-container.
Without regressing bug 595656?
Blocks: 595656
I'll override it with the page's stylesheet.
Attached patch fix — — Splinter Review
Assignee: nobody → geoff
Status: NEW → ASSIGNED
Attachment #630421 - Flags: review?(bmcbride)
Comment on attachment 630421 [details] [diff] [review]
fix

Review of attachment 630421 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/themes/gnomestripe/mozapps/extensions/newaddon.css
@@ +22,5 @@
>    -moz-box-flex: 3;
>  }
>  
>  #addon-container {
> +  overflow: visible; /* bug 761489 */

The bug number is easy enough to find in HG history - if it warrants a comment, it should be a direct description of why it's needed.
Attachment #630421 - Flags: review?(bmcbride) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ec43f1c0d12
No longer depends on: 492645
Flags: in-testsuite-
Flags: in-moztrap-
Flags: in-litmus-
Target Milestone: --- → mozilla16
Comment on attachment 630421 [details] [diff] [review]
fix

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 595656
User impact if declined: new addon page may become unusable if the buttons overflow off the bottom
Testing completed (on m-c, etc.): manually tested
Risk to taking this patch (and alternatives if risky): virtually none
String or UUID changes made by this patch: none
Attachment #630421 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/4ec43f1c0d12
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Attachment #630421 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Duplicate of this bug: 763919
Able to see the issue on Nightly 2012-06-05.
Verified fixed on FF 15b5 on Win 7, Ubuntu 12.04 and Mac OS X 10.6.
Status: RESOLVED → VERIFIED
status-firefox15: fixed → verified
You need to log in before you can comment on or make changes to this bug.