Closed Bug 76161 Opened 23 years ago Closed 23 years ago

Don't select "resolve as dup" radio button when exiting empty dupe field.

Categories

(Bugzilla :: Query/Bug List, defect, P3)

Product:
Bugzilla
Component:
Query/Bug List
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 2.16

People

(Reporter: CodeMachine, Assigned: endico)

Details

Attachments

(1 file)

Patch to make knob not select if entry field is emptied
845 bytes, patch
caillon
: review+
caillon
: review+
Details | Diff | Splinter Review 
There is currently code so that when I exit the "Resolve this bug as dupe of
[    ] field", the radio button for this line gets checked.

I unchecked it, and then when back and removed the number just to be sure.  Then
when I exited it selected the line again.  It should only do this when there is
something in the field.
Keywords: patch
Yep... that does the trick.  Tested on IE 5.5 (Win2k), Mozilla (recent build,
Win2k) and Netscape 6 (Linux).

r= jake@acutex.net
Target Milestone: --- → Bugzilla 2.16
*** Bug 52885 has been marked as a duplicate of this bug. ***
This is also a problem with the assignee (see duplicate).  Can you please extend
the patch?
I think you should reopen the other bug and leave it separate.  The assignee is a 
more complicated field because of having an initial value.  (see the comments in 
the other bug).  I can easily extend this patch to not select the radio button if 
the asignee field is blank, but getting it to not select if it's the original 
owner will be more difficult.

Oh yeah.  I guess it should never be blank since assignees shouldn't be blank.
I'll reopen.
Priority: -- → P3
Summary: Don't marking resolving duplicate when exiting empty dupe field. → Don't select "resolve as dup" radio button when exiting empty dupe field.
-> New product bugzilla
Assignee: tara → endico
Component: Bugzilla → Query/Bug List
Product: Webtools → Bugzilla
Version: other → unspecified
Comment on attachment 31507 [details] [diff] [review]
Patch to make knob not select if entry field is emptied

first review=jake
i'm giving r=caillon for second review now.
Attachment #31507 - Flags: review+
See also bug 96990.
/cvsroot/mozilla/webtools/bugzilla/bug_form.pl,v  <--  bug_form.pl
new revision: 1.74; previous revision: 1.73

Gerv
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: