761621 - interfaces inheriting a builtinclass-interface should be builtinclass too

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Hmm, there is 
+                IDL_tree_property_get(
+                  IDL_INTERFACE(iter).ident, "builtinclass")) {
+                IDL_tree_error(interface_tree,
+                               "%s is not [builtinclass] but extends "
+                               "[builtinclass] interface %s",
+                               IDL_IDENT(IDL_INTERFACE(interface_tree).ident).str,
+                               IDL_IDENT(IDL_INTERFACE(iter).ident).str);
+                return FALSE;

But I don't get that error with the patch for bug 761613

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Hmm, we don't have that error anymore in the python implementation.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Either do builtinclass implicitly, or error if inheriting builtinclass.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Yeah, I think implicit is bad. We should make it an error if a non-builtin inherits a builtin. That's what I was trying to implement, but maybe I went wrong somewhere. Possibly the problem is that it's not implemented correctly in the python XPIDL parser that we recently switched to.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=308af20708c2

Compiles at least locally.

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 630264 [details] [diff] [review]
patch

Review of attachment 630264 [details] [diff] [review]:
-----------------------------------------------------------------

I'm just assuming you got all the interfaces.  The xpidl.py changes are fine.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Trying some webapp hackery

This needs the patch for Bug 762007

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/5fb42dae7200