Closed
Bug 762007
Opened 9 years ago
Closed 9 years ago
mozIDOMApplicationMgmt inherits builtinclass so it must be implemented in C++, or changed to not inherit builtinclass
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: smaug, Assigned: smaug)
References
Details
Attachments
(2 files, 1 obsolete file)
2.49 KB,
patch
|
Details | Diff | Splinter Review | |
2.49 KB,
patch
|
fabrice
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
for now, could we just change mozIDOMApplicationMgmt to not inherit nsIDOMEventTarget?
Assignee | ||
Comment 2•9 years ago
|
||
...since the implementation doesn't seem to implement nsIDOMEventTarget anyway.
Assignee | ||
Comment 3•9 years ago
|
||
Updated•9 years ago
|
Component: Web Apps → DOM: Mozilla Extensions
Product: Firefox → Core
QA Contact: webapps → general
Assignee | ||
Comment 4•9 years ago
|
||
Why are webapp implementation bugs DOM bugs?
Comment 5•9 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #4) > Why are webapp implementation bugs DOM bugs? Core --> DOM:Mozilla Extensions is where bugs go for issues related to underlying mozapps API. Checking the changelog for the file being worked on, this file seems to be attached to that. Firefox --> Web Apps is front-end work for the end user for the install lifecycle for apps natively (e.g. install app, launch app). Myk's description a little while back summarizes it as: "The webapp runtime for Firefox, which comprises: the stub executable launcher (i.e. the binary and related files that Firefox creates for each webapp you install to your local computer) and the XUL shell (i.e. the XULRunner application that the launcher uses to load a webapp and provide it with native integration APIs). Note: bugs about Gecko's navigator.mozApps DOM API (i.e. the API that web pages use to request webapp installation) go in Core / DOM: Mozilla Extensions; bugs about Firefox's webapp installer (i.e. the feature that creates a launcher when the user approves an installation request) go in Firefox / Web Apps. "
Comment 6•9 years ago
|
||
(In reply to Jason Smith [:jsmith] from comment #5) > "The webapp runtime for Firefox, which comprises: the stub executable > launcher (i.e. the binary and related files that Firefox creates for each > webapp you install to your local computer) and the XUL shell (i.e. the > XULRunner application that the launcher uses to load a webapp and provide it > with native integration APIs). Note: bugs about Gecko's navigator.mozApps > DOM API (i.e. the API that web pages use to request webapp installation) go > in Core / DOM: Mozilla Extensions; bugs about Firefox's webapp installer > (i.e. the feature that creates a launcher when the user approves an > installation request) go in Firefox / Web Apps. " Note - this is pulled from Firefox --> Webapp Runtime
Assignee | ||
Comment 7•9 years ago
|
||
Need to fix the test, and also the event interface.
Attachment #630540 -
Attachment is obsolete: true
Assignee | ||
Comment 8•9 years ago
|
||
Attachment #630593 -
Flags: review?(fabrice)
Assignee | ||
Updated•9 years ago
|
Summary: mozIDOMApplicationMgmt inherits builtinclass so it must be implemented in C++ → mozIDOMApplicationMgmt inherits builtinclass so it must be implemented in C++, or changed to not inherit builtinclass
Updated•9 years ago
|
Attachment #630593 -
Flags: review?(fabrice) → review+
Assignee | ||
Comment 9•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/794751c0c8f4
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → bugs
Depends on: 765287
Updated•8 years ago
|
Component: DOM: Mozilla Extensions → DOM
Updated•2 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•