mozIDOMApplicationMgmt inherits builtinclass so it must be implemented in C++, or changed to not inherit builtinclass

RESOLVED FIXED

Status

()

RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Comment hidden (empty)
Blocks: 761621
for now, could we just change  mozIDOMApplicationMgmt to not inherit nsIDOMEventTarget?
...since the implementation doesn't seem to implement nsIDOMEventTarget anyway.
Component: Web Apps → DOM: Mozilla Extensions
Product: Firefox → Core
QA Contact: webapps → general
Why are webapp implementation bugs DOM bugs?
(In reply to Olli Pettay [:smaug] from comment #4)
> Why are webapp implementation bugs DOM bugs?

Core --> DOM:Mozilla Extensions is where bugs go for issues related to underlying mozapps API. Checking the changelog for the file being worked on, this file seems to be attached to that.

Firefox --> Web Apps is front-end work for the end user for the install lifecycle for apps natively (e.g. install app, launch app).

Myk's description a little while back summarizes it as:

"The webapp runtime for Firefox, which comprises: the stub executable launcher (i.e. the binary and related files that Firefox creates for each webapp you install to your local computer) and the XUL shell (i.e. the XULRunner application that the launcher uses to load a webapp and provide it with native integration APIs). Note: bugs about Gecko's navigator.mozApps DOM API (i.e. the API that web pages use to request webapp installation) go in Core / DOM: Mozilla Extensions; bugs about Firefox's webapp installer (i.e. the feature that creates a launcher when the user approves an installation request) go in Firefox / Web Apps. "
(In reply to Jason Smith [:jsmith] from comment #5)
> "The webapp runtime for Firefox, which comprises: the stub executable
> launcher (i.e. the binary and related files that Firefox creates for each
> webapp you install to your local computer) and the XUL shell (i.e. the
> XULRunner application that the launcher uses to load a webapp and provide it
> with native integration APIs). Note: bugs about Gecko's navigator.mozApps
> DOM API (i.e. the API that web pages use to request webapp installation) go
> in Core / DOM: Mozilla Extensions; bugs about Firefox's webapp installer
> (i.e. the feature that creates a launcher when the user approves an
> installation request) go in Firefox / Web Apps. "

Note - this is pulled from Firefox --> Webapp Runtime
Created attachment 630573 [details] [diff] [review]
WIP2

Need to fix the test, and also the event interface.
Attachment #630540 - Attachment is obsolete: true
Created attachment 630593 [details] [diff] [review]
patch
Attachment #630593 - Flags: review?(fabrice)
Summary: mozIDOMApplicationMgmt inherits builtinclass so it must be implemented in C++ → mozIDOMApplicationMgmt inherits builtinclass so it must be implemented in C++, or changed to not inherit builtinclass
Attachment #630593 - Flags: review?(fabrice) → review+
https://hg.mozilla.org/mozilla-central/rev/794751c0c8f4
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Assignee: nobody → bugs
Component: DOM: Mozilla Extensions → DOM
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.