761688 - JS error at shutdown when calling nsIControllers.removeController from convbrowser.xml

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Florian Quèze [:florian]]

Attachment: Patch

We have this JS error when closing Thunderbird if no conversation log has been displayed.

JavaScript error: , line 0: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIControllers.removeController]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://chat/content/convbrowser.xml :: destroy :: line 243"  data: no]

The cause is that the controller is only added when the document of the conversation is loaded; which never happens if the convbrowser used to display logs is never used.

Comment 1

[Patrick Cloke [:clokep]]

Comment on attachment 630211 [details] [diff] [review]
Patch

Review of attachment 630211 [details] [diff] [review]:
-----------------------------------------------------------------

This change looks good.

Comment 2

[Florian Quèze [:florian]]

http://hg.mozilla.org/comm-central/rev/e7896b8dd498

Comment 3

[Florian Quèze [:florian]]

Comment on attachment 630211 [details] [diff] [review]
Patch

[Approval Request Comment]
I would like to take this cleanup patch on aurora for Tb15, but it's not strictly required as nothing is visibly broken.

Comment 4

[Florian Quèze [:florian]]

https://hg.mozilla.org/releases/comm-aurora/rev/ab0ab330eb2f