The default bug view has changed. See this FAQ.

JS error at shutdown when calling nsIControllers.removeController from convbrowser.xml

RESOLVED FIXED in Thunderbird 16.0

Status

Thunderbird
Instant Messaging
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: florian, Assigned: florian)

Tracking

(Blocks: 1 bug)

Trunk
Thunderbird 16.0

Thunderbird Tracking Flags

(thunderbird15 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 630211 [details] [diff] [review]
Patch

We have this JS error when closing Thunderbird if no conversation log has been displayed.

JavaScript error: , line 0: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIControllers.removeController]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://chat/content/convbrowser.xml :: destroy :: line 243"  data: no]

The cause is that the controller is only added when the document of the conversation is loaded; which never happens if the convbrowser used to display logs is never used.
Attachment #630211 - Flags: review?(clokep)
Comment on attachment 630211 [details] [diff] [review]
Patch

Review of attachment 630211 [details] [diff] [review]:
-----------------------------------------------------------------

This change looks good.
Attachment #630211 - Flags: review?(clokep) → review+

Updated

5 years ago
Blocks: 738778

Updated

5 years ago
Assignee: nobody → florian
Status: NEW → ASSIGNED
(Assignee)

Comment 2

5 years ago
http://hg.mozilla.org/comm-central/rev/e7896b8dd498
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 16.0
(Assignee)

Comment 3

5 years ago
Comment on attachment 630211 [details] [diff] [review]
Patch

[Approval Request Comment]
I would like to take this cleanup patch on aurora for Tb15, but it's not strictly required as nothing is visibly broken.
Attachment #630211 - Flags: approval-comm-aurora?
Attachment #630211 - Flags: approval-comm-aurora? → approval-comm-aurora+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/releases/comm-aurora/rev/ab0ab330eb2f
status-thunderbird15: --- → fixed
You need to log in before you can comment on or make changes to this bug.