Closed
Bug 761688
Opened 12 years ago
Closed 12 years ago
JS error at shutdown when calling nsIControllers.removeController from convbrowser.xml
Categories
(Thunderbird :: Instant Messaging, defect)
Thunderbird
Instant Messaging
Tracking
(thunderbird15 fixed)
RESOLVED
FIXED
Thunderbird 16.0
Tracking | Status | |
---|---|---|
thunderbird15 | --- | fixed |
People
(Reporter: florian, Assigned: florian)
References
Details
Attachments
(1 file)
3.26 KB,
patch
|
clokep
:
review+
standard8
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
We have this JS error when closing Thunderbird if no conversation log has been displayed. JavaScript error: , line 0: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIControllers.removeController]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: chrome://chat/content/convbrowser.xml :: destroy :: line 243" data: no] The cause is that the controller is only added when the document of the conversation is loaded; which never happens if the convbrowser used to display logs is never used.
Attachment #630211 -
Flags: review?(clokep)
Comment 1•12 years ago
|
||
Comment on attachment 630211 [details] [diff] [review] Patch Review of attachment 630211 [details] [diff] [review]: ----------------------------------------------------------------- This change looks good.
Attachment #630211 -
Flags: review?(clokep) → review+
Assignee | ||
Comment 2•12 years ago
|
||
http://hg.mozilla.org/comm-central/rev/e7896b8dd498
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 16.0
Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 630211 [details] [diff] [review] Patch [Approval Request Comment] I would like to take this cleanup patch on aurora for Tb15, but it's not strictly required as nothing is visibly broken.
Attachment #630211 -
Flags: approval-comm-aurora?
Updated•12 years ago
|
Attachment #630211 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Assignee | ||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/releases/comm-aurora/rev/ab0ab330eb2f
status-thunderbird15:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•