Last Comment Bug 761720 - Port |Bug 474721 - messagereader: message header should not prefer the address book over the message headers as a source of display names|
: Port |Bug 474721 - messagereader: message header should not prefer the addres...
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: MailNews: Message Display (show other bugs)
: Trunk
: All All
: -- enhancement (vote)
: seamonkey2.13
Assigned To: Ian Neal (Away until 7th Aug)
:
Mentors:
Depends on: 131571 474721
Blocks: 763284 761852 773867
  Show dependency treegraph
 
Reported: 2012-06-05 11:25 PDT by Ian Neal (Away until 7th Aug)
Modified: 2013-08-18 08:39 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Simple port on top of patch from bug 131571 [Checked in: Comment 3] (7.42 KB, patch)
2012-06-05 11:26 PDT, Ian Neal (Away until 7th Aug)
mnyromyr: review+
mnyromyr: superreview+
Details | Diff | Splinter Review

Description Ian Neal (Away until 7th Aug) 2012-06-05 11:25:38 PDT
+++ This bug was initially created as a clone of Bug #474721 +++

In my neck of the woods, Evite is a very widely used event invitation system, and it sends out mails with headers like this:

From: Bill Schlep <info@mail.evite.com>
Reply-To: Bill Schlep <bills_real_address@foo.com>

They also include this string in the body of the message: "Did this email go to your junk/bulk folder?  Add info@evite.com to your address book to ensure that you receive future Evite Invitations in your Inbox." which explains the motivation (though they have a bug in that they changed the hostname their mail came from without updating the body text to match).

This means that currently, all evites that I get appear, in the compact header view, as though they came from whatever name is associated with info@evite.com, which happens to be whoever I got the evite from when I starred that address.  Very confusing.

ping, an up-and-coming web 2.0 invite site does something similar.

If an email has a display in the From header and we prefer that to anything from the address book, that fixes this problem.
Comment 1 Ian Neal (Away until 7th Aug) 2012-06-05 11:26:57 PDT
Created attachment 630237 [details] [diff] [review]
Simple port on top of patch from bug 131571 [Checked in: Comment 3]
Comment 2 Karsten Düsterloh 2012-06-08 16:33:42 PDT
Comment on attachment 630237 [details] [diff] [review]
Simple port on top of patch from bug 131571 [Checked in: Comment 3]

Just some nits:

>+        // And the "prefer display name" checkbox

"and" or full stop at the end.

>+  if (condense && cardDetails.card) {

Brace on its own line, please.


r/moa=me with that.
Comment 3 Ian Neal (Away until 7th Aug) 2012-06-09 15:45:24 PDT
Comment on attachment 630237 [details] [diff] [review]
Simple port on top of patch from bug 131571 [Checked in: Comment 3]

Checked in with points addressed:
http://hg.mozilla.org/comm-central/rev/172686daec10
Comment 4 bugzilla 2013-08-18 08:39:06 PDT
"always prefer display name over message header" in addressbook is no longer working in at least 2.19, one other user in Seamonkey IRC could replicate this bug.

Note You need to log in before you can comment on or make changes to this bug.