761720 - Port |Bug 474721 - messagereader: message header should not prefer the address book over the message headers as a source of display names|

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, enhancement)

Description

[Ian Neal]

+++ This bug was initially created as a clone of Bug #474721 +++

In my neck of the woods, Evite is a very widely used event invitation system, and it sends out mails with headers like this:

From: Bill Schlep <[e-mail]>
Reply-To: Bill Schlep <[e-mail]>

They also include this string in the body of the message: "Did this email go to your junk/bulk folder?  Add [e-mail] to your address book to ensure that you receive future Evite Invitations in your Inbox." which explains the motivation (though they have a bug in that they changed the hostname their mail came from without updating the body text to match).

This means that currently, all evites that I get appear, in the compact header view, as though they came from whatever name is associated with [e-mail], which happens to be whoever I got the evite from when I starred that address.  Very confusing.

ping, an up-and-coming web 2.0 invite site does something similar.

If an email has a display in the From header and we prefer that to anything from the address book, that fixes this problem.

Comment 1

[Ian Neal]

Attachment: Simple port on top of patch from bug 131571 [Checked in: Comment 3]

Comment 2

[Karsten Düsterloh]

Comment on attachment 630237 [details] [diff] [review]
Simple port on top of patch from bug 131571 [Checked in: Comment 3]

Just some nits:

>+        // And the "prefer display name" checkbox

"and" or full stop at the end.

>+  if (condense && cardDetails.card) {

Brace on its own line, please.


r/moa=me with that.

Comment 3

[Ian Neal]

Comment on attachment 630237 [details] [diff] [review]
Simple port on top of patch from bug 131571 [Checked in: Comment 3]

Checked in with points addressed:
http://hg.mozilla.org/comm-central/rev/172686daec10

Comment 4

[bugzilla]

"always prefer display name over message header" in addressbook is no longer working in at least 2.19, one other user in Seamonkey IRC could replicate this bug.