761729 - Either implement mozIDOMApplicationEvent in C++, or make WebApps use CustomEvent

Status: RESOLVED FIXED

Description

[Olli Pettay [:smaug]]

http://mxr.mozilla.org/mozilla-central/source/dom/apps/src/Webapps.js#399

DOMEvents will be forced to be C++ only. Right now properly implemented DOM Events
are already C++ only, but apparently there is at least one JS implementation too
(which doesn't work at all with event dispatching code).

Comment 1

[[:fabrice] Fabrice Desré]

Created attachment 633215 [details] [diff] [review]
patch

I had to refactor the IDL to move the Application object definition in its own file since it is use in the dictionnary, hence the include change to nsGlobalWindow.h

Comment 2

[Olli Pettay [:smaug]]

Comment on attachment 633215 [details] [diff] [review]
patch


>+[scriptable, uuid(b70b84f1-7ac9-4a92-bc32-8b6a7eb7879e)]
>+interface mozIDOMApplication  : nsISupports
Nit, extra space before :


>+{
>+  readonly attribute jsval manifest;
>+  readonly attribute DOMString manifestURL;
>+  readonly attribute nsIArray receipts; /* an array of strings */
Not about this bug, but huh. Why do we expose nsIArray to web. We really shouldn't do that.


But I don't understand why you need to move Application interface.

Comment 3

[[:fabrice] Fabrice Desré]

(In reply to Olli Pettay [:smaug] from comment #2)

> Not about this bug, but huh. Why do we expose nsIArray to web. We really
> shouldn't do that.

Yep, I plan to move that to a jsval.

> 
> But I don't understand why you need to move Application interface.

since the dictionnary is :
{
 mozIDOMApplication application;
}

and mozIDOMApplication is not a built-in type, the code generator that uses dictionary_helper_gen.conf looks for a "mozIDOMApplication.h" header file.

Comment 4

[Olli Pettay [:smaug]]

Couldn't you add mozIDOMApplication to exclude_automatic_type_include
and perhaps nsIDOMApplicationRegistry.h to special_includes

Comment 5

[Olli Pettay [:smaug]]

...in dictionary_helper_gen.conf

Comment 6

[[:fabrice] Fabrice Desré]

(In reply to Olli Pettay [:smaug] from comment #5)
> ...in dictionary_helper_gen.conf

I didn't know about these. I'll update my patch, thanks!

Comment 7

[[:fabrice] Fabrice Desré]

Created attachment 633285 [details] [diff] [review]
patch v2

Updated to use exclude_automatic_type_include.

Comment 8

[Olli Pettay [:smaug]]

Comment on attachment 633285 [details] [diff] [review]
patch v2

>+nsDOMMozApplicationEvent::GetApplication(mozIDOMApplication **aApplication)
Nit, mozIDOMApplication **aApplication


>+private:
>+  nsCOMPtr<mozIDOMApplication> mApplication;
Almost missed... you have strong pointer to Application, so you need to add it to
cycle collection. (You can check nsDOMCustomEvent as an example. It has mDetail as a strong member variable.)

Comment 9

[[:fabrice] Fabrice Desré]

Created attachment 633297 [details] [diff] [review]
patch v3

Now with cycle collection for mApplication.

Comment 10

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b6927b157cb3

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b6927b157cb3