Last Comment Bug 761797 - make the Preferences (options) menu item in Addressbook open the Composition panel and Addressing tab in the preferences dialog
: make the Preferences (options) menu item in Addressbook open the Composition ...
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Address Book (show other bugs)
: Trunk
: All All
: -- enhancement (vote)
: Thunderbird 17.0
Assigned To: :aceman
:
Mentors:
Depends on: 718139
Blocks: 525905
  Show dependency treegraph
 
Reported: 2012-06-05 14:40 PDT by :aceman
Modified: 2012-07-18 17:27 PDT (History)
3 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (4.07 KB, patch)
2012-07-17 14:40 PDT, :aceman
mconley: review+
mconley: ui‑review+
Details | Diff | Splinter Review

Description :aceman 2012-06-05 14:40:22 PDT
Make the Preferences (options) menu item in Addressbook open the Composition panel and Addressing tab in the preferences dialog. Currently it opens any panel/tab the user had open previously.
The same approach is already used in Compose window, which opens the Composition panel (no specific tab).
Of course the user is then free to switch to any other panel/tab.

Bug 718139 will provide the infrastructure for this, in this bug I wire up this specific panel + tab.
Comment 1 :aceman 2012-07-17 14:40:55 PDT
Created attachment 643148 [details] [diff] [review]
patch

The patch. And even some "command" conversion for mconley :) It looked like a good thing to do in this file.
Comment 2 Mike Conley (:mconley) - (needinfo me!) 2012-07-18 10:39:10 PDT
Comment on attachment 643148 [details] [diff] [review]
patch

Review of attachment 643148 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, and works correctly.

I'mma snag this ui-r from bwinton while I'm at it. This change makes perfect sense from a UI perspective, so thanks for that. :)
Comment 3 :aceman 2012-07-18 11:32:26 PDT
Thanks, that was fast :)
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-07-18 17:27:55 PDT
https://hg.mozilla.org/comm-central/rev/da351e536396

Note You need to log in before you can comment on or make changes to this bug.