761890 - [Skia] Fix Skia bugs which prevent Azure canvas tests from passing

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Comment 1

[Nick Cameron [:nrc]]

Attachment: patch 1: build Skia under Windows

Comment 2

[Nick Cameron [:nrc]]

Attachment: patch 2: changes to Skia font handling

Moved from Bug 746883 and rebased. Carrying r=gw280

Comment 3

[Nick Cameron [:nrc]]

Attachment: patch 3: Fixing Skia/Azure font things on the

Moved from Bug 746883 and rebased carrying r=gw280

Comment 4

[George Wright (:gw280) (needinfo me!)]

Comment on attachment 630439 [details] [diff] [review]
patch 1: build Skia under Windows

Review of attachment 630439 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good otherwise, please run it through try first for all platforms.

::: gfx/skia/update.sh
@@ +50,5 @@
>  cp $1/src/ports/*.cpp ./src/ports/
>  cp $1/src/svg/*.cpp ./src/svg/
>  cp $1/src/svg/*.h ./src/svg/
> +cp $1/src/sfnt/*.cpp ./src/svg/
> +cp $1/src/sfnt/*.h ./src/svg/

Need to update the target directory here

Comment 5

[Nick Cameron [:nrc]]

Attachment: patch 1: build Skia under Windows

Fixed. Running on Try right now.

Comment 6

[Nick Cameron [:nrc]]

Try push (builds): https://tbpl.mozilla.org/?tree=Try&rev=5ff61477b1a4

Comment 7

[Nick Cameron [:nrc]]

Try push: https://tbpl.mozilla.org/?tree=Try&rev=173cfa8a92ad

Comment 8

[Nick Cameron [:nrc]]

Attachment: patch 4: tests which now pass

moved from Bug 746883, guarded with azureSkia rather than making pass, carrying r=gw280,jmuizelaar

Comment 9

[Nick Cameron [:nrc]]

Attachment: patch 5: tweaks to other tests

Moved from bug 746883, carrying r=ggw280,jmuizelaar

Comment 10

[Nick Cameron [:nrc]]

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=88c6ee3a9aef

Comment 11

[Matt Brubeck (:mbrubeck)]

Sorry, I had to back this out on inbound because of a reftest.list syntax error and a leak in debug reftests:
https://hg.mozilla.org/integration/mozilla-inbound/rev/253d5996845e

Comment 12

[Jesse Ruderman]

> #fails with Skia due to Skia bug 568

This confuses my after-fix tool.  I'd prefer a hyperlink into their bug tracker.

Comment 13

[Nick Cameron [:nrc]]

(In reply to Jesse Ruderman from comment #12)
> > #fails with Skia due to Skia bug 568
> 
> This confuses my after-fix tool.  I'd prefer a hyperlink into their bug
> tracker.

http://code.google.com/p/skia/issues/detail?id=568

Comment 14

[Nick Cameron [:nrc]]

Another Try push: https://tbpl.mozilla.org/?tree=Try&rev=5b27bac1b664

Comment 15

[Nick Cameron [:nrc]]

Attachment: patch 5: tweaks to other tests

Added a hyperlink in a comment for Jesse (comment 11), carrying r=gw280,jmuizelaar

Comment 16

[Nick Cameron [:nrc]]

Trying again to land: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=8c1c326ed100

Comment 17

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a24de192b216
https://hg.mozilla.org/mozilla-central/rev/c2539605ff49
https://hg.mozilla.org/mozilla-central/rev/856142f34511
https://hg.mozilla.org/mozilla-central/rev/e3af4396672d
https://hg.mozilla.org/mozilla-central/rev/8c1c326ed100