[Skia] Fix Skia bugs which prevent Azure canvas tests from passing

RESOLVED FIXED in mozilla16

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: nrc, Assigned: nrc)

Tracking

15 Branch
mozilla16
x86_64
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments, 2 obsolete attachments)

Comment hidden (empty)
(Assignee)

Updated

5 years ago
Blocks: 746883
No longer depends on: 746883
Blocks: 761895
(Assignee)

Comment 1

5 years ago
Created attachment 630439 [details] [diff] [review]
patch 1: build Skia under Windows
Attachment #630439 - Flags: review?(gwright)
(Assignee)

Comment 2

5 years ago
Created attachment 630442 [details] [diff] [review]
patch 2: changes to Skia font handling

Moved from Bug 746883 and rebased. Carrying r=gw280
Attachment #630442 - Flags: review+
(Assignee)

Comment 3

5 years ago
Created attachment 630443 [details] [diff] [review]
patch 3: Fixing Skia/Azure font things on the

Moved from Bug 746883 and rebased carrying r=gw280
Attachment #630443 - Flags: review+
Comment on attachment 630439 [details] [diff] [review]
patch 1: build Skia under Windows

Review of attachment 630439 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good otherwise, please run it through try first for all platforms.

::: gfx/skia/update.sh
@@ +50,5 @@
>  cp $1/src/ports/*.cpp ./src/ports/
>  cp $1/src/svg/*.cpp ./src/svg/
>  cp $1/src/svg/*.h ./src/svg/
> +cp $1/src/sfnt/*.cpp ./src/svg/
> +cp $1/src/sfnt/*.h ./src/svg/

Need to update the target directory here
Attachment #630439 - Flags: review?(gwright) → review-
(Assignee)

Comment 5

5 years ago
Created attachment 630448 [details] [diff] [review]
patch 1: build Skia under Windows

Fixed. Running on Try right now.
Attachment #630439 - Attachment is obsolete: true
Attachment #630448 - Flags: review?(gwright)
(Assignee)

Comment 6

5 years ago
Try push (builds): https://tbpl.mozilla.org/?tree=Try&rev=5ff61477b1a4
Attachment #630448 - Flags: review?(gwright) → review+
(Assignee)

Comment 7

5 years ago
Try push: https://tbpl.mozilla.org/?tree=Try&rev=173cfa8a92ad
(Assignee)

Comment 8

5 years ago
Created attachment 631195 [details] [diff] [review]
patch 4: tests which now pass

moved from Bug 746883, guarded with azureSkia rather than making pass, carrying r=gw280,jmuizelaar
Attachment #631195 - Flags: review+
(Assignee)

Comment 9

5 years ago
Created attachment 631196 [details] [diff] [review]
patch 5: tweaks to other tests

Moved from bug 746883, carrying r=ggw280,jmuizelaar
Attachment #631196 - Flags: review+
No longer blocks: 761895
(Assignee)

Comment 10

5 years ago
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=88c6ee3a9aef
Target Milestone: --- → mozilla16
Sorry, I had to back this out on inbound because of a reftest.list syntax error and a leak in debug reftests:
https://hg.mozilla.org/integration/mozilla-inbound/rev/253d5996845e
Target Milestone: mozilla16 → ---

Comment 12

5 years ago
> #fails with Skia due to Skia bug 568

This confuses my after-fix tool.  I'd prefer a hyperlink into their bug tracker.
(Assignee)

Comment 13

5 years ago
(In reply to Jesse Ruderman from comment #12)
> > #fails with Skia due to Skia bug 568
> 
> This confuses my after-fix tool.  I'd prefer a hyperlink into their bug
> tracker.

http://code.google.com/p/skia/issues/detail?id=568
(Assignee)

Comment 14

5 years ago
Another Try push: https://tbpl.mozilla.org/?tree=Try&rev=5b27bac1b664
Target Milestone: --- → mozilla16
(Assignee)

Comment 15

5 years ago
Created attachment 633009 [details] [diff] [review]
patch 5: tweaks to other tests

Added a hyperlink in a comment for Jesse (comment 11), carrying r=gw280,jmuizelaar
Attachment #631196 - Attachment is obsolete: true
Attachment #633009 - Flags: review+
(Assignee)

Updated

5 years ago
Target Milestone: mozilla16 → ---
(Assignee)

Comment 16

5 years ago
Trying again to land: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=8c1c326ed100
Target Milestone: --- → mozilla16

Updated

5 years ago
Depends on: 765038
https://hg.mozilla.org/mozilla-central/rev/a24de192b216
https://hg.mozilla.org/mozilla-central/rev/c2539605ff49
https://hg.mozilla.org/mozilla-central/rev/856142f34511
https://hg.mozilla.org/mozilla-central/rev/e3af4396672d
https://hg.mozilla.org/mozilla-central/rev/8c1c326ed100
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.