Closed Bug 761890 Opened 8 years ago Closed 8 years ago

[Skia] Fix Skia bugs which prevent Azure canvas tests from passing

Categories

(Core :: Graphics, defect)

15 Branch
x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: nrc, Assigned: nrc)

References

Details

Attachments

(5 files, 2 obsolete files)

No description provided.
Blocks: 746883
No longer depends on: 746883
Attachment #630439 - Flags: review?(gwright)
Moved from Bug 746883 and rebased. Carrying r=gw280
Attachment #630442 - Flags: review+
Moved from Bug 746883 and rebased carrying r=gw280
Attachment #630443 - Flags: review+
Comment on attachment 630439 [details] [diff] [review]
patch 1: build Skia under Windows

Review of attachment 630439 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good otherwise, please run it through try first for all platforms.

::: gfx/skia/update.sh
@@ +50,5 @@
>  cp $1/src/ports/*.cpp ./src/ports/
>  cp $1/src/svg/*.cpp ./src/svg/
>  cp $1/src/svg/*.h ./src/svg/
> +cp $1/src/sfnt/*.cpp ./src/svg/
> +cp $1/src/sfnt/*.h ./src/svg/

Need to update the target directory here
Attachment #630439 - Flags: review?(gwright) → review-
Fixed. Running on Try right now.
Attachment #630439 - Attachment is obsolete: true
Attachment #630448 - Flags: review?(gwright)
Attachment #630448 - Flags: review?(gwright) → review+
moved from Bug 746883, guarded with azureSkia rather than making pass, carrying r=gw280,jmuizelaar
Attachment #631195 - Flags: review+
Attached patch patch 5: tweaks to other tests (obsolete) — Splinter Review
Moved from bug 746883, carrying r=ggw280,jmuizelaar
Attachment #631196 - Flags: review+
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=88c6ee3a9aef
Target Milestone: --- → mozilla16
Sorry, I had to back this out on inbound because of a reftest.list syntax error and a leak in debug reftests:
https://hg.mozilla.org/integration/mozilla-inbound/rev/253d5996845e
Target Milestone: mozilla16 → ---
> #fails with Skia due to Skia bug 568

This confuses my after-fix tool.  I'd prefer a hyperlink into their bug tracker.
(In reply to Jesse Ruderman from comment #12)
> > #fails with Skia due to Skia bug 568
> 
> This confuses my after-fix tool.  I'd prefer a hyperlink into their bug
> tracker.

http://code.google.com/p/skia/issues/detail?id=568
Another Try push: https://tbpl.mozilla.org/?tree=Try&rev=5b27bac1b664
Target Milestone: --- → mozilla16
Added a hyperlink in a comment for Jesse (comment 11), carrying r=gw280,jmuizelaar
Attachment #631196 - Attachment is obsolete: true
Attachment #633009 - Flags: review+
Target Milestone: mozilla16 → ---
Trying again to land: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=8c1c326ed100
Target Milestone: --- → mozilla16
Depends on: 765038
You need to log in before you can comment on or make changes to this bug.