Closed Bug 761961 Opened 13 years ago Closed 13 years ago

Typing 8 when a message is selected produces an error in the console

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 16.0

People

(Reporter: Usul, Assigned: aceman)

Details

Attachments

(1 file, 1 obsolete file)

Select a message , press 8 in the error console you get the following error Timestamp: 6/6/12 11:13:48 AM Error: An error occurred executing the cmd_tag8 command: TypeError: tagArray[keyNumber - 1] is undefined Source File: chrome://global/content/globalOverlay.js Line: 79
OS: Mac OS X → All
Actually it adds a tag for me, that is in the context menu under Tags and has a accesskey of 8. This probably just needs a check if there is a tag defined under that number. I'll try it.
Assignee: nobody → acelists
Attached patch patch (obsolete) — Splinter Review
Attachment #631091 - Flags: review?(mconley)
Status: NEW → ASSIGNED
Hardware: x86 → All
Comment on attachment 631091 [details] [diff] [review] patch Review of attachment 631091 [details] [diff] [review]: ----------------------------------------------------------------- Just one super tiny nit. With that fixed, r=me. ::: mail/base/content/mailWindowOverlay.js @@ +562,5 @@ > if (!msgHdr) > return; > > let tagArray = MailServices.tags.getAllTags({}); > + if (tagArray.length < keyNumber) Sorry for being super super picky, but I think I'd prefer if (keyNumber > tagArray.length) I know they're semantically equivalent, but I think it reads easier based on what's expected; "the keynumber the user pressed was out of range" as opposed to "the expected range is outside of the keynumber".
Attachment #631091 - Flags: review?(mconley) → review+
Attached patch patch v2Splinter Review
What a nit ;)
Attachment #631091 - Attachment is obsolete: true
Usul, try to verify once this lands.
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 16.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: