Improve content/html/content/tests/forms/test_progress_element.html

RESOLVED FIXED in mozilla16

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Trunk
mozilla16
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 630564 [details] [diff] [review]
Patch

Some changes in bug 686913 weren't the best actually.
Attachment #630564 - Flags: review?(Ms2ger)
Comment on attachment 630564 [details] [diff] [review]
Patch

Review of attachment 630564 [details] [diff] [review]:
-----------------------------------------------------------------

Sure
Attachment #630564 - Flags: review?(Ms2ger) → review+
(Assignee)

Updated

5 years ago
Depends on: 762435
(Assignee)

Comment 2

5 years ago
Created attachment 630923 [details] [diff] [review]
Patch v2

Trivial change: the element is now labelable.
Attachment #630564 - Attachment is obsolete: true
Attachment #630923 - Flags: review?(Ms2ger)
Comment on attachment 630923 [details] [diff] [review]
Patch v2

Review of attachment 630923 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the description fixed.

::: content/html/content/test/forms/test_progress_element.html
@@ +222,5 @@
> +  var label = document.createElement('label');
> +
> +  content.appendChild(label);
> +  label.appendChild(aElement);
> +  is(label.control, aElement, "progress should not be labelable");

not?
Attachment #630923 - Flags: review?(Ms2ger) → review+
(Assignee)

Updated

5 years ago
Flags: in-testsuite+
Target Milestone: --- → mozilla16
(Assignee)

Updated

5 years ago
Attachment #630923 - Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/113a75e9bf67
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.