762435 - Make progress labelable again

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch

That was broken in bug 686913.

Tests will come with bug 762047.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 630920 [details] [diff] [review]
Patch

r=me

Comment 2

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0f7995b75365

Comment 3

[Mounir Lamouri (:mounir)]

Comment on attachment 630920 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 686913
User impact if declined: <label><progress></progress></label> will not work
Risk to taking this patch (and alternatives if risky): low, labelling might not work as expected.
String or UUID changes made by this patch: none with that one, but some with bug 762434 like Element UUID update.

Comment 4

[Alex Keybl [:akeybl]]

(In reply to Mounir Lamouri (:volkmar) (:mounir) from comment #3)
> String or UUID changes made by this patch: none with that one, but some with
> bug 762434 like Element UUID update.

Is this fix dependent on bug 762434? Will it be nominated for Aurora approval as well?

Comment 5

[Mounir Lamouri (:mounir)]

(In reply to Alex Keybl [:akeybl] from comment #4)
> (In reply to Mounir Lamouri (:volkmar) (:mounir) from comment #3)
> > String or UUID changes made by this patch: none with that one, but some with
> > bug 762434 like Element UUID update.
> 
> Is this fix dependent on bug 762434? Will it be nominated for Aurora
> approval as well?

Indeed. I forgot about that. It is now done.

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 630920 [details] [diff] [review]
Patch

[Triage Comment]
Approved along with bug 762434, we should have sufficient bake time on this to catch regressions.

Comment 7

[Mounir Lamouri (:mounir)]

Pushed in Aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/bde27ed49c7c

Comment 8

[Scoobidiver (away)]

Target Milestone is for m-c.

Comment 9

[Ioana (away)]

Verified as fixed on:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:15.0) Gecko/20100101 Firefox/15.0
Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20100101 Firefox/15.0
Build identifier: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20100101 Firefox/15.0

Progress is labelable again.