Last Comment Bug 762079 - crash in nsFileStreamBase::MaybeOpen , Startup crash with WebMail Notifier
: crash in nsFileStreamBase::MaybeOpen , Startup crash with WebMail Notifier
Status: RESOLVED FIXED
: crash, regression, topcrash
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: 16 Branch
: All All
: -- critical (vote)
: mozilla16
Assigned To: Geoff Lankow (:darktrojan)
:
Mentors:
: 762257 762355 (view as bug list)
Depends on:
Blocks: 749930
  Show dependency treegraph
 
Reported: 2012-06-06 09:08 PDT by Alice0775 White
Modified: 2012-06-15 17:57 PDT (History)
8 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (1.60 KB, patch)
2012-06-06 16:07 PDT, Geoff Lankow (:darktrojan)
bent.mozilla: review+
Details | Diff | Review

Description Alice0775 White 2012-06-06 09:08:10 PDT
This bug was filed from the Socorro interface and is 
report bp-6f65bec3-398a-49c9-8966-b98182120606 .
============================================================= 
Build Identifier:
http://hg.mozilla.org/mozilla-central/rev/6338a8988917
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/16.0 Firefox/16.0a1 ID:20120606030528

Startup crash with WebMail Notifier https://addons.mozilla.org/ja/firefox/addon/webmail-notifier/


Steps to Reproduce:

1. Start Browser with new profile
2. Install WebMail Notifier https://addons.mozilla.org/ja/firefox/addon/webmail-notifier/
3. Restart

Actual Results:  
  Crashes

Regression window
Good:
http://hg.mozilla.org/mozilla-central/rev/a567f52fa0d8
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/16.0 Firefox/16.0a1 ID:20120605163217
Crashes:
http://hg.mozilla.org/mozilla-central/rev/a15d75939cd5
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/16.0 Firefox/16.0a1 ID:20120605191018
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a567f52fa0d8&tochange=a15d75939cd5

Triggered by:
a15d75939cd5	Geoff Lankow — Bug 749930 - Replace uses of nsILocalFile with nsIFile (compiled code only); r=bsmedberg
Comment 1 Alice0775 White 2012-06-06 09:14:26 PDT
Windows7 : bp-5cd8598f-4a12-41c9-bbb0-238cd2120606
Ubuntu10.04: bp-96d030ba-31e3-4449-9ab2-a50922120606
Comment 2 Ben Turner (not reading bugmail, use the needinfo flag!) 2012-06-06 09:27:16 PDT
This used to use do_QueryInterface to make it null safe. Now that has been removed.
Comment 3 Scoobidiver (away) 2012-06-06 12:15:47 PDT
There are about 150 crashes an hour.
Comment 4 Geoff Lankow (:darktrojan) 2012-06-06 16:07:26 PDT
Created attachment 630754 [details] [diff] [review]
fix

Also cleans up a stray nsresult.
Comment 5 Ben Turner (not reading bugmail, use the needinfo flag!) 2012-06-06 16:34:34 PDT
Comment on attachment 630754 [details] [diff] [review]
fix

The old code returned NS_ERROR_UNEXPECTED if the QI failed. Who knows if anyone depends on it, but please leave it that way.

r=me with that change.
Comment 6 Geoff Lankow (:darktrojan) 2012-06-06 16:46:31 PDT
https://hg.mozilla.org/mozilla-central/rev/c779db92fef2
Comment 7 Matthias Versen [:Matti] 2012-06-06 17:28:15 PDT
*** Bug 762257 has been marked as a duplicate of this bug. ***
Comment 8 Scoobidiver (away) 2012-06-07 00:40:21 PDT
*** Bug 762355 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.