The default bug view has changed. See this FAQ.

Use nsScriptErrorEvent when firing error events on window objects

RESOLVED FIXED in mozilla16

Status

()

Core
DOM: IndexedDB
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ben Turner (not reading bugmail, use the needinfo flag!), Assigned: khuey)

Tracking

unspecified
mozilla16
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

We fire a plain Event at them now, but that doesn't unwrap properly when hitting window.onerror. The fix is to use nsScriptErrorEvent.
Created attachment 637147 [details] [diff] [review]
Patch
Assignee: nobody → khuey
Status: NEW → ASSIGNED
Attachment #637147 - Flags: review?(bent.mozilla)
Comment on attachment 637147 [details] [diff] [review]
Patch

Review of attachment 637147 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with that fixed

::: dom/indexedDB/IDBObjectStore.cpp
@@ +1464,5 @@
>    if (!IsWriteAllowed()) {
>      return NS_ERROR_DOM_INDEXEDDB_READ_ONLY_ERR;
>    }
>  
> +  nsRefPtr<IDBRequest> request = GenerateRequest(this, nsnull);

Why null here?
Attachment #637147 - Flags: review?(bent.mozilla) → review+
Because that function is only called in the parent process when doing IPC indexedDB, so there's no script information to get.
Bent explained why things work the way they do. Nothing to see here, move along. r+ stands.
https://hg.mozilla.org/mozilla-central/rev/939191463ed4
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.